You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/24 07:13:53 UTC

[GitHub] sijie opened a new pull request #1435: Issue #1434: Checkstyle are not executed at some modules

sijie opened a new pull request #1435: Issue #1434: Checkstyle are not executed at some modules
URL: https://github.com/apache/bookkeeper/pull/1435
 
 
   
   Descriptions of the changes in this PR:
   
   *Motivation*
   
   Checkstyle was supposed to run at `validate` phase for every modules. However checkstyle is not running at some modules.
   This introduces inconsistency between modules.
   
   *Changes*
   
   - Fix Checkstyle warnings.
   - Remove `checkstyle` plugins from modules, only leave it at root pom file or modules that have overrides. This improves default build time.
   - Add `checkstyle:check` to CI jobs.
   
   *NOTES*
   
   `microbenchmarks` has too many checkstyle volations. so skip checkstyle for this PR.
   
   
   
   Master Issue: #1434 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services