You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2011/06/29 08:05:30 UTC
[jira] [Created] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Convert store/updatelocks.sql to JUnit
--------------------------------------
Key: DERBY-5305
URL: https://issues.apache.org/jira/browse/DERBY-5305
Project: Derby
Issue Type: Improvement
Reporter: Dag H. Wanvik
Priority: Minor
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Attachment: (was: derby-5305-a.stat)
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Mike Matrigali (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali resolved DERBY-5305.
-----------------------------------
Resolution: Fixed
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.8.2.3, 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057229#comment-13057229 ]
Knut Anders Hatlen commented on DERBY-5305:
-------------------------------------------
Whoa! A 2.68 MB patch! :D
The new test looks clean and systematic, so I'd say commit it. I must admit I haven't read every single line of the patch, but just to prove that I have looked at it, here are my nit-picks:
- In decorateSQL(), auto-commit is turned off and commit() is called explicitly at the end of the method. This is not necessary, since CleanDatabaseTestSetup already turns off auto-commit before calling decorateSQL() and commits immediately afterwards.
- Most of the code in decorateSQL() is commented out. Could it be removed?
- One of the added lines in JDBC.java has trailing blanks.
- In tearDown(), I'd suggest using the helper method BaseJDBCTestCase.dropTable().
- Closing getLocksQuery in tearDown() shouldn't be necessary since it was created with BaseJDBCTestCase.prepareStatement() and will be closed in super.tearDown(). Setting the reference to null would be good, though, so that the statement and the connection can be garbage collected after the test case has completed.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Component/s: Test
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Priority: Minor
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061462#comment-13061462 ]
Dag H. Wanvik commented on DERBY-5305:
--------------------------------------
Committed a patch to this end as svn 1143939.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059393#comment-13059393 ]
Dag H. Wanvik commented on DERBY-5305:
--------------------------------------
Regressions ran OK, committed as svn 1142626.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061220#comment-13061220 ]
Kristian Waagan commented on DERBY-5305:
----------------------------------------
Committed a trivial cleanup as revision 1143768: removed two unused imports and removed an unused variable.
The method 'show' is currently unused. Is this something that is useful for debugging, or can it be removed? If the former, maybe a comment saying so would be useful?
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Issue & fix info: (was: [Patch Available])
Fix Version/s: 10.9.0.0
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-5305.
----------------------------------
Resolution: Fixed
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Issue & fix info: [Patch Available]
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061422#comment-13061422 ]
Dag H. Wanvik commented on DERBY-5305:
--------------------------------------
Yes, the show method was useful when making the test and I see it being potentially useful when debugging the test if it ever starts to fail. I'll add a Javadoc comment and comment out the whole for now for good measure.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Attachment: (was: derby-5305-a.diff)
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057145#comment-13057145 ]
Dag H. Wanvik commented on DERBY-5305:
--------------------------------------
A comment on my approach to the conversion: I used the existing canons and converted them semi-automatically into corresponding Java result set tuples for the assertions, to ensure the test semantics are retained.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Mike Matrigali (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali reopened DERBY-5305:
-----------------------------------
reopening to backport to 10.8.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Mike Matrigali (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-5305:
----------------------------------
Fix Version/s: 10.8.2.3
backported the fix to 10.8. 10.8 was seeing some intermittent failures in updatelocks.sql test, so backporting this will eliminate those and I have not
seen any intermittent errors assocated with the new UpdateLocks converted test.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.8.2.3, 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5305) Convert store/updatelocks.sql to JUnit
Posted by "Mike Matrigali (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali closed DERBY-5305.
---------------------------------
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.8.2.3, 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5305) Convert store/updatelocks.sql to JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik closed DERBY-5305.
--------------------------------
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Attachment: derby-5305-a.stat
derby-5305-a.diff
Uploading a patch which converts updatelocks.sql into JUnit: UpdateLocksTest.
It also contains a fix to JDBC.assertUnorderedResultSet for a bug when trimming is not used.
Running regressions.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reassigned DERBY-5305:
------------------------------------
Assignee: Dag H. Wanvik
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057763#comment-13057763 ]
Dag H. Wanvik commented on DERBY-5305:
--------------------------------------
Thanks for the comments, Knut. As for the commented out decorateSQL code, I was torn on whether to remove it or retain it since it was part of the original test (although unused), but kept it till review time so someone else could chime in on it... ;-) Now that you spotted it, I'm +1 to removing it unless someone closer to the original authorship of this test feels it should stay.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5305) Convert store/updatelocks.sql to
JUnit
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5305:
---------------------------------
Attachment: derby-5305-b.stat
derby-5305-b.diff.gz
Uploading version "b" incorporating Knut's suggestions including removing the cruft. I also got rid of some too long lines. Re-running regressions. This time I upload a gzipped version of the patch ("b") and I will also remove the first 2.5Mb version ("a") to save some space. If somebody want to see the first version, I will retain it for some time.
> Convert store/updatelocks.sql to JUnit
> --------------------------------------
>
> Key: DERBY-5305
> URL: https://issues.apache.org/jira/browse/DERBY-5305
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-5305-a.diff, derby-5305-a.stat, derby-5305-b.diff.gz, derby-5305-b.stat
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira