You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/03/10 06:30:22 UTC

[GitHub] [phoenix] kadirozde commented on a change in pull request #1161: PHOENIX-6408 LIMIT on local index query with uncovered columns in the WHERE returns wrong result.

kadirozde commented on a change in pull request #1161:
URL: https://github.com/apache/phoenix/pull/1161#discussion_r591104351



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
##########
@@ -240,6 +245,9 @@ public boolean nextRaw(List<Cell> result) throws IOException {
                     return next;
                 }
             }
+            if (extraLimit >= 0 && --extraLimit == 0) {

Review comment:
       Should not this check be at the end of this method just before it returns?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org