[3/7] incubator-brooklyn git commit: TaskFinalizer: add TODO about logging

[al...@apache.org]

TaskFinalizer: add TODO about logging

Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/69e2f865
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/69e2f865
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/69e2f865

Branch: refs/heads/master
Commit: 69e2f86501a5b4b9397d4aa5db96e89abfada40b
Parents: 6416575
Author: Aled Sage <al...@gmail.com>
Authored: Thu Nov 6 13:41:13 2014 +0000
Committer: Aled Sage <al...@gmail.com>
Committed: Thu Nov 6 13:41:13 2014 +0000

----------------------------------------------------------------------
 core/src/main/java/brooklyn/util/task/BasicTask.java | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/69e2f865/core/src/main/java/brooklyn/util/task/BasicTask.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/brooklyn/util/task/BasicTask.java b/core/src/main/java/brooklyn/util/task/BasicTask.java
index c478336..e666680 100644
--- a/core/src/main/java/brooklyn/util/task/BasicTask.java
+++ b/core/src/main/java/brooklyn/util/task/BasicTask.java
@@ -756,6 +756,8 @@ public class BasicTask<T> implements TaskInternal<T> {
             }
             if (!t.isDone()) {
                 // shouldn't happen
+                // TODO But does happen if management context was terminated (e.g. running test suite).
+                //      Should check if Execution Manager is running, and only log if it was not terminated?
                 log.warn("Task "+t+" is being finalized before completion");
                 return;
             }