[GitHub] [iceberg] openinx commented on a change in pull request #2945: Core: Add new writer interfaces

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2945:
URL: https://github.com/apache/iceberg/pull/2945#discussion_r696232779



##########
File path: core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -56,10 +57,17 @@ public EqualityDeleteWriter(FileAppender<T> appender, FileFormat format, String
     this.equalityFieldIds = equalityFieldIds;
   }
 
+  @Override
+  public void write(T row) throws IOException {
+    appender.add(row);
+  }
+
+  @Deprecated

Review comment:
       We don't expose those `deleteAll` and `delete` methods in the public `iceberg-api` module,  so is there any neccessary to keep those deprecated API for at least a release ?  I'm thinking that we could just remove those from this class.

##########
File path: core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java
##########
@@ -55,15 +56,27 @@ public PositionDeleteWriter(FileAppender<StructLike> appender, FileFormat format
     this.pathSet = CharSequenceSet.empty();
   }
 
+  @Override
+  public void write(PositionDelete<T> positionDelete) throws IOException {
+    pathSet.add(positionDelete.path());

Review comment:
       Nit: I think it's clear to rename `pathSet` as `referencedDataFiles`.  When I check this variable at the first glance,  I was thinking: `pathSet` ?  which path set ?  what's used for.   I did not get it until I checked the `referencedDataFiles()` method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org