You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/04 18:38:05 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11936: chore: consolidate common code in importers
betodealmeida opened a new pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR removes duplicate code used for the new importers:
1. It adds a base class to the Python importers, since the atomic execution and validation are common for all imports.
2. It creates a generic import modal to be used by all imports in the frontend.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Tested imports on the browser, and ran unit tests.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.10%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.35% -4.11%
============================================
Files 920 918 -2
Lines 44819 44558 -261
Branches 4246 4247 +1
============================================
- Hits 30235 28231 -2004
- Misses 14481 16148 +1667
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.67% <97.01%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [199 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (290d93c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.41%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 64.16% +0.41%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18273 -10829
+ Misses 16369 10205 -6164
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.16% <97.05%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...44e0ebb](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (290d93c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.11%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 63.86% +0.11%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18187 -10915
+ Misses 16369 10291 -6078
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.86% <97.05%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [484 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...44e0ebb](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540410160
##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -68,11 +145,11 @@ const ImportChartModal: FunctionComponent<ImportChartModalProps> = ({
const {
state: { passwordsNeeded },
importResource,
- } = useImportResource<ChartObject>('chart', t('chart'), handleErrorMsg);
+ } = useImportResource<any>(resourceName, resourceLabel, handleErrorMsg);
Review comment:
We actually don't need this, I removed it in https://github.com/apache/incubator-superset/pull/12003 to avoid having to rebuild this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540333257
##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -68,11 +145,11 @@ const ImportChartModal: FunctionComponent<ImportChartModalProps> = ({
const {
state: { passwordsNeeded },
importResource,
- } = useImportResource<ChartObject>('chart', t('chart'), handleErrorMsg);
+ } = useImportResource<any>(resourceName, resourceLabel, handleErrorMsg);
Review comment:
+1 with elizabeth, where you union all the types allowed to be imported.
@eschutho that's what you meant right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (290d93c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.11%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 63.87% +0.11%
==========================================
Files 941 466 -475
Lines 45648 28463 -17185
Branches 4388 0 -4388
==========================================
- Hits 29102 18180 -10922
+ Misses 16369 10283 -6086
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.87% <97.05%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [491 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...44e0ebb](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.10%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.35% -4.11%
============================================
Files 920 460 -460
Lines 44819 28036 -16783
Branches 4246 0 -4246
============================================
- Hits 30235 17762 -12473
+ Misses 14481 10274 -4207
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.35% <97.05%> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540334383
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -526,16 +530,26 @@ function DashboardList(props: DashboardListProps) {
);
}}
</ConfirmStatusChange>
- <ImportDashboardModal
+
+ <ImportModelsModal
+ resourceName="dashboard"
+ resourceLabel={t('dashboard')}
+ icon={<StyledIcon name="nav-dashboard" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
Review comment:
nit: i'd put this as a constant at the top
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540405392
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -526,16 +530,26 @@ function DashboardList(props: DashboardListProps) {
);
}}
</ConfirmStatusChange>
- <ImportDashboardModal
+
+ <ImportModelsModal
+ resourceName="dashboard"
+ resourceLabel={t('dashboard')}
+ icon={<StyledIcon name="nav-dashboard" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
Review comment:
Addressed in https://github.com/apache/incubator-superset/pull/12002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540390892
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and ' +
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
TBH, we used inline functions all the time in the past, so I never gave that concern much weight.. I've heard arguments for/against, but I will research the latest stance on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (2297f9b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.27%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 64.02% +0.27%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18234 -10868
+ Misses 16369 10244 -6125
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.02% <97.05%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...2297f9b](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.03%`.
> The diff coverage is `96.38%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.42% -4.04%
============================================
Files 920 918 -2
Lines 44819 44559 -260
Branches 4246 4247 +1
============================================
- Hits 30235 28263 -1972
- Misses 14481 16117 +1636
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.78% <97.05%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.45%`.
> The diff coverage is `97.01%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.00% -4.46%
============================================
Files 920 460 -460
Lines 44819 28035 -16784
Branches 4246 0 -4246
============================================
- Hits 30235 17664 -12571
+ Misses 14481 10371 -4110
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.00% <97.01%> (-1.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (+7.79%)` | :arrow_up: |
| ... and [483 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.45%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.00% -4.46%
============================================
Files 920 460 -460
Lines 44819 28036 -16783
Branches 4246 0 -4246
============================================
- Hits 30235 17665 -12570
+ Misses 14481 10371 -4110
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.00% <97.05%> (-1.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [484 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.03%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.42% -4.04%
============================================
Files 920 918 -2
Lines 44819 44558 -261
Branches 4246 4247 +1
============================================
- Hits 30235 28261 -1974
- Misses 14481 16118 +1637
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.77% <97.01%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540469268
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and ' +
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
Inline functions are fine for functional components. I have yet to see it causing performance issues. The only way it could cause performance issues is when the child component is expensive to re-render and the functional props are the only dependency that is updating between parent re-renders.
If re-render is a real concern, the common practice is to put functions within `useCallback`, or move them out of the functional component. Here is this case there is no additional benefits since the named function is still within the functional component, will be a new variable each time the parent component renders, thus always triggers a re-render of the child component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540469268
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and ' +
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
Inline functions are fine for functional components. I have yet to see it causing performance issues. The only way it could cause performance issues is when the child component is expensive to re-render and the functional props are the only dependency that is updating between parent re-renders.
If re-render is a real concern, the common practice is to put functions within `useCallback`, or move them out of the functional component. Here is this case there is no additional benefits since the named function is still within the functional component and not wrapped with `useCallback`, will be a new variable each time the parent component re-renders, thus always triggers a re-render of the child component as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r539766806
##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -68,11 +145,11 @@ const ImportChartModal: FunctionComponent<ImportChartModalProps> = ({
const {
state: { passwordsNeeded },
importResource,
- } = useImportResource<ChartObject>('chart', t('chart'), handleErrorMsg);
+ } = useImportResource<any>(resourceName, resourceLabel, handleErrorMsg);
Review comment:
You mean using an union of all types instead of `any`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `3.92%`.
> The diff coverage is `96.38%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.53% -3.93%
============================================
Files 920 918 -2
Lines 44819 44559 -260
Branches 4246 4247 +1
============================================
- Hits 30235 28310 -1925
- Misses 14481 16070 +1589
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.95% <97.05%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (2297f9b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **decrease** coverage by `0.54%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
- Coverage 63.75% 63.20% -0.55%
==========================================
Files 941 466 -475
Lines 45648 28463 -17185
Branches 4388 0 -4388
==========================================
- Hits 29102 17990 -11112
+ Misses 16369 10473 -5896
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.20% <97.05%> (-1.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...2297f9b](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (2297f9b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.27%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 64.02% +0.27%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18233 -10869
+ Misses 16369 10245 -6124
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.02% <97.05%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...2297f9b](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.03%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.42% -4.04%
============================================
Files 920 918 -2
Lines 44819 44558 -261
Branches 4246 4247 +1
============================================
- Hits 30235 28263 -1972
- Misses 14481 16116 +1635
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.78% <97.01%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (2297f9b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.10%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 63.85% +0.10%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18186 -10916
+ Misses 16369 10292 -6077
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.85% <97.05%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...2297f9b](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `3.92%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.53% -3.93%
============================================
Files 920 918 -2
Lines 44819 44558 -261
Branches 4246 4247 +1
============================================
- Hits 30235 28309 -1926
- Misses 14481 16070 +1589
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.94% <97.01%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r539735080
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and ' +
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
did you want to just use `()=> showImportModal(false);` here instead or are you aiming to be more explicit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (290d93c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8f1ac7ead18d7df05dd0f307250caf592347baea?el=desc) (8f1ac7e) will **increase** coverage by `0.40%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11936 +/- ##
==========================================
+ Coverage 63.75% 64.15% +0.40%
==========================================
Files 941 466 -475
Lines 45648 28478 -17170
Branches 4388 0 -4388
==========================================
- Hits 29102 18270 -10832
+ Misses 16369 10208 -6161
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.15% <97.05%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [8f1ac7e...44e0ebb](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r539766663
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and ' +
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
I've been conditioned by the AirBnB linter to never inline functions in props. My understanding is that it has a performance cost, but that might've changed with functional components?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r540356814
##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -68,11 +145,11 @@ const ImportChartModal: FunctionComponent<ImportChartModalProps> = ({
const {
state: { passwordsNeeded },
importResource,
- } = useImportResource<ChartObject>('chart', t('chart'), handleErrorMsg);
+ } = useImportResource<any>(resourceName, resourceLabel, handleErrorMsg);
Review comment:
yeah, that's what I was thinking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.52%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 62.94% -4.53%
============================================
Files 920 918 -2
Lines 44819 44544 -275
Branches 4246 4247 +1
============================================
- Hits 30235 28036 -2199
- Misses 14481 16329 +1848
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.00% <97.01%> (-1.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [214 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `3.67%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.78% -3.68%
============================================
Files 920 460 -460
Lines 44819 28050 -16769
Branches 4246 0 -4246
============================================
- Hits 30235 17891 -12344
+ Misses 14481 10159 -4322
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.78% <97.05%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.03%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.42% -4.04%
============================================
Files 920 918 -2
Lines 44819 44558 -261
Branches 4246 4247 +1
============================================
- Hits 30235 28262 -1973
- Misses 14481 16117 +1636
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.78% <97.01%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [191 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.09%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.36% -4.10%
============================================
Files 920 460 -460
Lines 44819 28036 -16783
Branches 4246 0 -4246
============================================
- Hits 30235 17764 -12471
+ Misses 14481 10272 -4209
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.36% <97.05%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `91.17% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (+5.30%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+2.77%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `94.11% <100.00%> (ø)` | |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#discussion_r539733506
##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -68,11 +145,11 @@ const ImportChartModal: FunctionComponent<ImportChartModalProps> = ({
const {
state: { passwordsNeeded },
importResource,
- } = useImportResource<ChartObject>('chart', t('chart'), handleErrorMsg);
+ } = useImportResource<any>(resourceName, resourceLabel, handleErrorMsg);
Review comment:
do you want to constrain this with a set of type arguments for each type of model? You can do the same for the resourceName.. not a blocker, though, just if you want to make the types stronger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (69a7ac7) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.02%`.
> The diff coverage is `96.38%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 63.43% -4.03%
============================================
Files 920 918 -2
Lines 44819 44559 -260
Branches 4246 4247 +1
============================================
- Hits 30235 28264 -1971
- Misses 14481 16116 +1635
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.78% <97.05%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.50% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| ... and [191 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org