[GitHub] sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.
URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r242781707
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java
 ##########
 @@ -550,4 +564,14 @@ protected BookieNode replaceFromRack(BookieNode bookieNodeToReplace,
         finalList.addMissingIndices(ensemble.size());
         return finalList;
     }
+
+    @Override
+    public boolean isEnsembleAdheringToPlacementPolicy(List<BookieSocketAddress> ensembleList, int writeQuorumSize,
+            int ackQuorumSize) {
+        /**
+         * TODO: have to implement actual logic for this method for
 
 Review comment:
   can you create the issue and put the issue link in the comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services