You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/12 07:20:51 UTC

[GitHub] [pulsar] wolfstudy opened a new pull request #8540: Support key base for python function

wolfstudy opened a new pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540


   ### Motivation
   
   The changing base on #8523 
   
   ### Modifications
   
   Support key base for python function
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#issuecomment-730089065


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#issuecomment-729330838


   @wolfstudy the change looks good. But I think we introduced a feature to support end-to-end encryption in Pulsar Function in #8432. I think we need to include this support for python functions as well. In this change, there is code generated for crypto reader. Can you create an issue to follow up to add this support?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on a change in pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#discussion_r527339665



##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
##########
@@ -26,15 +26,7 @@
 import org.apache.commons.lang3.StringUtils;
 import org.apache.pulsar.client.admin.PulsarAdmin;
 import org.apache.pulsar.client.admin.PulsarAdminException;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.MessageId;
-import org.apache.pulsar.client.api.Producer;
-import org.apache.pulsar.client.api.PulsarClient;
-import org.apache.pulsar.client.api.Reader;
-import org.apache.pulsar.client.api.Schema;
-import org.apache.pulsar.client.api.SubscriptionInitialPosition;
-import org.apache.pulsar.client.api.SubscriptionType;
+import org.apache.pulsar.client.api.*;

Review comment:
       Sure, will fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#issuecomment-728672791


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#issuecomment-731080802


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on a change in pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#discussion_r527071429



##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
##########
@@ -26,15 +26,7 @@
 import org.apache.commons.lang3.StringUtils;
 import org.apache.pulsar.client.admin.PulsarAdmin;
 import org.apache.pulsar.client.admin.PulsarAdminException;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.MessageId;
-import org.apache.pulsar.client.api.Producer;
-import org.apache.pulsar.client.api.PulsarClient;
-import org.apache.pulsar.client.api.Reader;
-import org.apache.pulsar.client.api.Schema;
-import org.apache.pulsar.client.api.SubscriptionInitialPosition;
-import org.apache.pulsar.client.api.SubscriptionType;
+import org.apache.pulsar.client.api.*;

Review comment:
       Can we avoid using wildcard import?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #8540: Support key base for python function

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8540:
URL: https://github.com/apache/pulsar/pull/8540#issuecomment-729336214


   > @wolfstudy the change looks good. But I think we introduced a feature to support end-to-end encryption in Pulsar Function in #8432. I think we need to include this support for python functions as well. In this change, there is code generated for crypto reader. Can you create an issue to follow up to add this support?
   
   Sure, will process it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org