You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/14 11:51:48 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

cloud-fan commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs
URL: https://github.com/apache/spark/pull/27579#discussion_r379391569
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -2106,13 +2106,19 @@ object SQLConf {
     .booleanConf
     .createWithDefault(false)
 
-  val LEGACY_CTE_PRECEDENCE_ENABLED = buildConf("spark.sql.legacy.ctePrecedence.enabled")
+  object LegacyBehaviorPolicy extends Enumeration {
+    val EXCEPTION, LEGACY, NEW_BEHAVIOR = Value
 
 Review comment:
   how about `CORRECTED` to indicate that it's the corrected behavior?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org