[jira] [Closed] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

["Jacques Le Roux (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-11986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-11986.
-----------------------------------
    Fix Version/s: Upcoming Branch
       Resolution: Fixed

Thanks Akashk and Sourabh,

Sourabh, you missed the 2nd point from Akash. Actually you missed much more. Actually OFBIZ-11413 was a total mess, not your fault ;). OFBIZ-11572 which reuses createPartyGroupRoleAndContactMechs has the same issue. I did not even try to explain you how to cope with these issues because I had to struggle to undersand what the problems were :/.

The crux of the problems was the call to createPartyContactMechs as a service. Before it was a simple-method call. And how to call a service and a simple-method is different (parameters vs minilang context). I'll not get into all details but for the email address in case of the service an emailAddressContext Map is expected not an emailAddress String. This of course entails more changes.

Sincerely If I had knew I'd not have started that work :D. Anyway it now works.

If you have the guts (be ready ;)), the work is still not complete: createPartyGroupRoleAndContactMechs (account), createPersonRoleAndContactMechs (lead) and createPartyContactMechs (used by both) should be converted to Groovy

I have created OFBIZ-12034 for that an will put some more information there later...

This said it's a pity nobody tested the feature by creating an account and a lead from the UI. It's easy to do and to check.

> createPartyGroupRoleAndContactMechs service not working
> -------------------------------------------------------
>
>                 Key: OFBIZ-11986
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11986
>             Project: OFBiz
>          Issue Type: Bug
>          Components: sfa
>    Affects Versions: Trunk
>            Reporter: Akash Jain
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11986.patch
>
>
> While researched on ticket OFBIZ-11896 identified that groovy version of createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two reasons,
>  # resolvePartyGroupMap called incorrectly
>  # resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly as 'postalAddress' and 'telecomNumber' map processor not available into PartyMapProcs.xml.
> There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)