[GitHub] [storm] RuiLi8080 commented on a change in pull request #3108: [STORM-3492] Add config to prevent good supervisor with bad workers f…

[GitBox <gi...@apache.org>]

RuiLi8080 commented on a change in pull request #3108: [STORM-3492] Add config to prevent good supervisor with bad workers f…
URL: https://github.com/apache/storm/pull/3108#discussion_r315882560
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
 ##########
 @@ -89,6 +90,7 @@ public void prepare(Map<String, Object> conf) {
         badSupervisorsToleranceSlidingWindow = EvictingQueue.create(windowSize);
         cachedSupervisors = new HashMap<>();
         blacklistHost = new HashSet<>();
+        blacklistOnBadSlots = ObjectReader.getBoolean(this.conf.get(DaemonConfig.BLACKLIST_SUPERVISOR_ON_BAD_SLOT), true);
 
 Review comment:
   Other variables using this format have default value set in default.yaml as well. And the ObjectReader.getBoolean() function require a default input. Should I still make change here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services