You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "krlmlr (via GitHub)" <gi...@apache.org> on 2023/06/08 01:34:30 UTC
[GitHub] [arrow-adbc] krlmlr opened a new pull request, #742: fix(r): Fix parameter binding when inferring types and when retrieving
krlmlr opened a new pull request, #742:
URL: https://github.com/apache/arrow-adbc/pull/742
Needs tests on the C side and perhaps also on the R side. Please advise.
Closes #734.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] krlmlr commented on pull request #742: fix(r): Fix parameter binding when inferring types and when retrieving
Posted by "krlmlr (via GitHub)" <gi...@apache.org>.
krlmlr commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1581759555
What should happen if parameters are required but not provided? What if there's a mismatch (parameter count or parameter names)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] krlmlr commented on pull request #742: fix(c/driver/sqlite): Fix parameter binding when inferring types and when retrieving
Posted by "krlmlr (via GitHub)" <gi...@apache.org>.
krlmlr commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1583974635
Interesting test failures. I can take a look at what's causing them, unless you do that first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #742: fix(c/driver/sqlite): Fix parameter binding when inferring types and when retrieving
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1587802800
Ah, I think what's happening now is that the batch size is also limited by the number of rows emitted from binding a parameter. Before it would (accidentally) aggregate rows from multiple parameters into a single batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #742: fix(c/driver/sqlite): Fix parameter binding when inferring types and when retrieving
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #742: fix(r): Fix parameter binding when inferring types and when retrieving
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1581776805
See https://github.com/apache/arrow-adbc/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] krlmlr commented on pull request #742: fix(r): Fix parameter binding when inferring types and when retrieving
Posted by "krlmlr (via GitHub)" <gi...@apache.org>.
krlmlr commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1581761037
@lidavidm: Triage rights here and on nanoarrow for Nicolas and me would be great so that we can request reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #742: fix(c/driver/sqlite): Fix parameter binding when inferring types and when retrieving
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1583302170
It seems reasonable, what we could do is add a new test to adbc_validation.cc
That said it seems possibly we already have tests that cover this and were written wrongly? Or this is causing tests to fail otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #742: fix(c/driver/sqlite): Fix parameter binding when inferring types and when retrieving
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1587906422
See https://github.com/krlmlr/arrow-adbc/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org