You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Rita Zhang <no...@github.com> on 2016/07/01 23:14:22 UTC
[jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image name
logic (#295)
@nacx I have updated the logic for creating custom image. Now `testCreateImage()` passes in`BaseImageExtensionLiveTest`.
@jtjk FYI.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/295
-- Commit Summary --
* JCLOUDS-664 Azurecompute-arm Update image name logic
-- File Changes --
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java (7)
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeImageExtension.java (3)
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/VMImageToImage.java (9)
M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/functions/CleanupResources.java (7)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/295.patch
https://github.com/jclouds/jclouds-labs/pull/295.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Ladislav Thon <no...@github.com>.
> @@ -79,12 +78,6 @@ public Boolean apply(String id) {
> boolean deploymentDeleteStatus = false;
>
> if (jobDone) {
> - StorageService ss = api.getStorageAccountApi(group).get(storageAccountName);
> - if (ss != null) {
> - storageAcctDeleteStatus = api.getStorageAccountApi(group).delete(storageAccountName);
> - } else {
> - storageAcctDeleteStatus = true;
> - }
I wonder why are storage accounts no longer deleted? What the provider creates when creating the node, it should also destroy when destroying the node, no?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295/files/b28c76c76590dfaa100a044504fadf4f088f538e#r70611207
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Rita Zhang <no...@github.com>.
> @@ -79,12 +78,6 @@ public Boolean apply(String id) {
> boolean deploymentDeleteStatus = false;
>
> if (jobDone) {
> - StorageService ss = api.getStorageAccountApi(group).get(storageAccountName);
> - if (ss != null) {
> - storageAcctDeleteStatus = api.getStorageAccountApi(group).delete(storageAccountName);
> - } else {
> - storageAcctDeleteStatus = true;
> - }
@Ladicek Currently, Azure ImageExtension is still a WIP. @jtjk is currently working on this.
Because the Azure capture image feature requires the new image to be stored in a storage account container, `createImage()` adds the image blob into the same storage account the node is created with. For `CleanupResources`, I temporarily removed the logic that deletes storage account when a node is destroyed because deleting the storage account will also delete all the custom images stored in that storage account. Once ImageExtension is completed, we will be able to query images stored in a storage account and delete a storage account only when no custom image exists.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295/files/b28c76c76590dfaa100a044504fadf4f088f538e#r70626132
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [6a51667e](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6a51667e). Many thanks @ritazh!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295#issuecomment-232191863
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Ladislav Thon <no...@github.com>.
> @@ -79,12 +78,6 @@ public Boolean apply(String id) {
> boolean deploymentDeleteStatus = false;
>
> if (jobDone) {
> - StorageService ss = api.getStorageAccountApi(group).get(storageAccountName);
> - if (ss != null) {
> - storageAcctDeleteStatus = api.getStorageAccountApi(group).delete(storageAccountName);
> - } else {
> - storageAcctDeleteStatus = true;
> - }
@ritazh That totally makes sense, thanks!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295/files/b28c76c76590dfaa100a044504fadf4f088f538e#r70626702
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Ignasi Barrera <no...@github.com>.
Closed #295.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295#event-720790003
Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm Update image
name logic (#295)
Posted by Rita Zhang <no...@github.com>.
@nacx @andreaturli _bump_
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/295#issuecomment-230871843