[GitHub] ctubbsii commented on a change in pull request #545: fixes #543 Avoid logLock when determining WALs in use

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #545: fixes #543 Avoid logLock when determining WALs in use
URL: https://github.com/apache/accumulo/pull/545#discussion_r199632158
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2518,6 +2518,7 @@ synchronized void finishClearingUnusedLogs() {
   }
 
   private Set<DfsLogger> otherLogs = Collections.emptySet();
+  // logs related to minor compaction file being added to the metadata table
 
 Review comment:
   This wording is a bit confusing. Can you expand on how they are related? Something like "Doomed logs are logs leftover from task X and will be deleted" (or whatever).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services