You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/06/02 23:47:26 UTC
[kudu-CR] Bump LLVM to 4.0.0
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7069
to review the following change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Bump LLVM to 4.0.0
Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
---
M thirdparty/download-thirdparty.sh
A thirdparty/package-llvm.sh
D thirdparty/patches/libc++-fix-std-once-barriers.patch
M thirdparty/vars.sh
4 files changed, 25 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7069/1
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7069/1//COMMIT_MSG
Commit Message:
Line 7: Bump LLVM to 4.0.0
> Can you explain why you want to do this? I mean, it's generally a reasonabl
Done
http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/package-llvm.sh
File thirdparty/package-llvm.sh:
Line 1: #!/bin/bash
> Add copyright notice and a brief header explaining what this does.
Done
Line 5: VERSION=4.0.0
> Make this settable via variable. Something like:
Done
Line 8: do
> Nit: move this to the previous line and separate with a semicolon; I think
Done
http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/vars.sh
File thirdparty/vars.sh:
PS1, Line 134: # Summary:
: # 1. Unpack the llvm tarball
: # 2. Unpack the clang tarball as tools/clang (rename from cfe-<version> to clang)
: # 3. Unpack the extra clang tools tarball as tools/clang/tools/extra
: # 4. Unpack the lld tarball as tools/lld
: # 5. Unpack the compiler-rt tarball as projects/compiler-rt
: # 6. Unpack the libc++ tarball as projects/libcxx
: # 7. Unpack the libc++abi tarball as projects/libcxxabi
: # 8. Create new tarball from the resulting source tree
> Move this description to package-llvm.sh.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7069/2/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 128: # Our llvm tarball includes clang, extra clang tools, lld, and compiler-rt.
> No need to duplicate this list (which may change over time), so instead, re
Done
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Bump LLVM to 4.0.0
......................................................................
Bump LLVM to 4.0.0
I'm working on integrating Thrift into the Kudu build, and hit
https://reviews.llvm.org/D22800, which is fixed in 4.0.0.
Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Reviewed-on: http://gerrit.cloudera.org:8080/7069
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/package-llvm.sh
D thirdparty/patches/libc++-fix-std-once-barriers.patch
M thirdparty/vars.sh
4 files changed, 58 insertions(+), 106 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7069/2/thirdparty/vars.sh
File thirdparty/vars.sh:
Line 128: # Our llvm tarball includes clang, extra clang tools, lld, and compiler-rt.
No need to duplicate this list (which may change over time), so instead, replace this with a pointer to package-llvm.sh.
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7069
to look at the new patch set (#3).
Change subject: Bump LLVM to 4.0.0
......................................................................
Bump LLVM to 4.0.0
I'm working on integrating Thrift into the Kudu build, and hit
https://reviews.llvm.org/D22800, which is fixed in 4.0.0.
Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
---
M thirdparty/download-thirdparty.sh
A thirdparty/package-llvm.sh
D thirdparty/patches/libc++-fix-std-once-barriers.patch
M thirdparty/vars.sh
4 files changed, 58 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7069/3
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Bump LLVM to 4.0.0
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7069/1//COMMIT_MSG
Commit Message:
Line 7: Bump LLVM to 4.0.0
Can you explain why you want to do this? I mean, it's generally a reasonable thing to do, but would be good to explain how this fixes the Thrift TSAN build (and link to the corresponding tsan patch, etc.)
http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/package-llvm.sh
File thirdparty/package-llvm.sh:
Line 1: #!/bin/bash
Add copyright notice and a brief header explaining what this does.
Line 5: VERSION=4.0.0
Make this settable via variable. Something like:
VERSION=${VERSION:4.0.0}
(apologies if that's not the right syntax).
Maybe even omit the default since it's going to be wrong for the next upgrade anyway.
Line 8: do
Nit: move this to the previous line and separate with a semicolon; I think that's the bash style we tend to use elsewhere.
http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/vars.sh
File thirdparty/vars.sh:
PS1, Line 134: # Summary:
: # 1. Unpack the llvm tarball
: # 2. Unpack the clang tarball as tools/clang (rename from cfe-<version> to clang)
: # 3. Unpack the extra clang tools tarball as tools/clang/tools/extra
: # 4. Unpack the lld tarball as tools/lld
: # 5. Unpack the compiler-rt tarball as projects/compiler-rt
: # 6. Unpack the libc++ tarball as projects/libcxx
: # 7. Unpack the libc++abi tarball as projects/libcxxabi
: # 8. Create new tarball from the resulting source tree
Move this description to package-llvm.sh.
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Bump LLVM to 4.0.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).
Change subject: Bump LLVM to 4.0.0
......................................................................
Bump LLVM to 4.0.0
I'm working on integrating Thrift into the Kudu build, and hit
https://reviews.llvm.org/D22800, which is fixed in 4.0.0.
Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
---
M thirdparty/download-thirdparty.sh
A thirdparty/package-llvm.sh
D thirdparty/patches/libc++-fix-std-once-barriers.patch
M thirdparty/vars.sh
4 files changed, 57 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7069/2
--
To view, visit http://gerrit.cloudera.org:8080/7069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>