[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #4659:
URL: https://github.com/apache/incubator-nuttx/pull/4659#discussion_r727627443



##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -243,18 +243,54 @@ static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
 
   else if ((flags & TCP_REXMIT) != 0)
     {
+#if defined(CONFIG_NET_TCP_SPLIT)
       /* Yes.. in this case, reset the number of bytes that have been sent
        * to the number of bytes that have been ACKed.
        */
 
       pstate->snd_sent = pstate->snd_acked;

Review comment:
       Yes, it does. I wrote about this in the PR summary. It contradicts to RFC 6298 (5.4) and other TCP related RFCs. Possibly it was done intentionally as a workaround (as I understand, CONFIG_NET_TCP_SPLIT algorithm is some sort of a trick as it is described in the source code comments).
   If CONFIG_NET_TCP_SPLIT was planned to be removed, the removing would simplify this part of the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org