[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table
URL: https://github.com/apache/incubator-hudi/pull/978#discussion_r340192722
 
 

 ##########
 File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java
 ##########
 @@ -329,7 +329,7 @@ private void init() throws IOException {
     // Add partitioning fields to writer schema for resulting row to contain null values for these fields
     String partitionFields = jobConf.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS, "");
     List<String> partitioningFields =
-        partitionFields.length() > 0 ? Arrays.stream(partitionFields.split(",")).collect(Collectors.toList())
+        partitionFields.length() > 0 ? Arrays.stream(partitionFields.split("/")).collect(Collectors.toList())
 
 Review comment:
   Thanks @zhedoubushishi for detailed information. This looks fine to me. Can you also add an integration test for MOR Table supporting multi-partition keys ? You can look at this class ITTestHoodieSanity.java. Currently, it does not have test case for MOR table. You can also look at HoodieJavaApp.java which is being called by  ITTestHoodieSanity.java to get an idea. Let me know if you need any help and we can help you on this.
   
   BTW, Good catch. Thanks for your contribution :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services