You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/12/13 04:08:00 UTC
[GitHub] tajo pull request: TAJO-1246: HBase info port conflict occasionall...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/300
TAJO-1246: HBase info port conflict occasionally causes unit test failur...
...es in Jenkins CI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1246
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit c9ce83db3bb7c858f0d0f3c3d7fc8ba11ebbb1a3
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-13T03:06:50Z
TAJO-1246: HBase info port conflict occasionally causes unit test failures in Jenkins CI.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1246: HBase info port conflict occasionall...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/300#issuecomment-66966199
Thank you @jinossy for the quick review. I'll reflect your comment, and then I'll commit it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1246: HBase info port conflict occasionall...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/300#issuecomment-66940430
+1
The patch looks good to me.
I left one comment. Before committing the patch, please reflect the comment if you accept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1246: HBase info port conflict occasionall...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1246: HBase info port conflict occasionall...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/300#discussion_r21802273
--- Diff: tajo-core/src/test/java/org/apache/tajo/HBaseTestClusterUtil.java ---
@@ -104,6 +104,8 @@ public void startHBaseCluster() throws Exception {
createRootDir();
Configuration c = HBaseConfiguration.create(this.conf);
+ // randomize hbase info port
+ c.setInt("hbase.master.info.port", 0);
--- End diff --
Could you change to {{HConstants.MASTER_INFO_PORT}} ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---