You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Deneche A. Hakim (JIRA)" <ji...@apache.org> on 2015/04/29 03:29:06 UTC
[jira] [Updated] (DRILL-2894) FixedValueVectors shouldn't set it's
data buffer to null when it fails to allocate it
[ https://issues.apache.org/jira/browse/DRILL-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deneche A. Hakim updated DRILL-2894:
------------------------------------
Description:
this is related to DRILL-2893
In _FixedValueVectors.java_ the following allocation methods will set the _data_ field to null if they fail to allocate properly:
- _allocateNewSafe()_
- _allocateNew(int valueCount)_
- _reAlloc()_
This will cause 2 problems:
1. both _allocateNew(int valueCount)_ and _reAlloc()_ will throw a _NullPointerException_ when it fails to allocate. This is somewhat properly taken care of by the calling code
2. when the operators are cleaning up, calling _clear()_ on a vector with a null data buffer will throw a _NullPointerException_ preventing the cleanup from finishing up properly
_VariableLengthVectors.java_ has a similar problem
was:
this is related to DRILL-2893
In _FixedValueVectors.java_ the following allocation methods will set the _data_ field to null if they fail to allocate properly:
- _allocateNewSafe()_
- _allocateNew(int valueCount)_
- _reAlloc()_
This will cause 2 problems:
1. both _allocateNew(int valueCount)_ and _reAlloc()_ will throw a _NullPointerException_ when it fails to allocate. This is somewhat properly taken care of by the calling code
2. when the operators are cleaning up, calling _clear()_ on a vector with a null data buffer will throw a _NullPointerException_ preventing the cleanup from finishing up properly
> FixedValueVectors shouldn't set it's data buffer to null when it fails to allocate it
> -------------------------------------------------------------------------------------
>
> Key: DRILL-2894
> URL: https://issues.apache.org/jira/browse/DRILL-2894
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
> Reporter: Deneche A. Hakim
> Assignee: Deneche A. Hakim
> Fix For: 1.0.0
>
>
> this is related to DRILL-2893
> In _FixedValueVectors.java_ the following allocation methods will set the _data_ field to null if they fail to allocate properly:
> - _allocateNewSafe()_
> - _allocateNew(int valueCount)_
> - _reAlloc()_
> This will cause 2 problems:
> 1. both _allocateNew(int valueCount)_ and _reAlloc()_ will throw a _NullPointerException_ when it fails to allocate. This is somewhat properly taken care of by the calling code
> 2. when the operators are cleaning up, calling _clear()_ on a vector with a null data buffer will throw a _NullPointerException_ preventing the cleanup from finishing up properly
> _VariableLengthVectors.java_ has a similar problem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)