You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/08/11 08:55:43 UTC
Review Request 37346: LENS-693: Query Result Mail is not working when
finishedQueries is set to zero
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review94909
-----------------------------------------------------------
Changes look fine. Please update testing done wrt finished queries set to zero.
- Amareshwari Sriramadasu
On Aug. 11, 2015, 6:55 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 6:55 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review95072
-----------------------------------------------------------
Overall changes look fine. Can you include unit tests for new functionality added in email notifier?
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 200)
<https://reviews.apache.org/r/37346/#comment149889>
What are the causes of LensException here ?
Should we cath Throwable here ?
- Amareshwari Sriramadasu
On Aug. 12, 2015, 9:56 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 9:56 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review97258
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 487)
<https://reviews.apache.org/r/37346/#comment153095>
One in-memory result that is not fetched should not block other queries to be purged. Can you check if that can happen?
- Amareshwari Sriramadasu
On Aug. 27, 2015, 12:47 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 12:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa3ef3d111b5d1728f6df854623b9effbfb
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s]
> [INFO] Lens .............................................. SUCCESS [3.146s]
> [INFO] Lens API .......................................... SUCCESS [21.540s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.002s]
> [INFO] Lens Cube ......................................... SUCCESS [5:06.032s]
> [INFO] Lens DB storage ................................... SUCCESS [19.632s]
> [INFO] Lens Query Library ................................ SUCCESS [17.437s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s]
> [INFO] Lens Server ....................................... SUCCESS [6:10.729s]
> [INFO] Lens client ....................................... SUCCESS [38.716s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.862s]
> [INFO] Lens Examples ..................................... SUCCESS [10.414s]
> [INFO] Lens Distribution ................................. SUCCESS [8.630s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s]
> [INFO] Lens Regression ................................... SUCCESS [10.184s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:30.753s
> [INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015
> [INFO] Final Memory: 192M/1814M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Sept. 22, 2015, 2:06 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 184
> > <https://reviews.apache.org/r/37346/diff/7/?file=1080131#file1080131line184>
> >
> > Does the private scope need change?
Yes. testresultformatting accesses it.
> On Sept. 22, 2015, 2:06 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 471
> > <https://reviews.apache.org/r/37346/diff/7/?file=1080131#file1080131line471>
> >
> > Result set may not available for all queries.
> >
> > Should be check isResultAvailable check instead of catching exception and unnecessary for log ?
There is no function `isResultAvailable`. We only have a function to check result availability in the driver.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99948
-----------------------------------------------------------
On Sept. 22, 2015, 1:43 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 1:43 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/main/webapp/static/index.html 70aa6bf151b67fde9aaa8372f0fe3c164f1e786d
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s]
> [INFO] Lens .............................................. SUCCESS [3.146s]
> [INFO] Lens API .......................................... SUCCESS [21.540s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.002s]
> [INFO] Lens Cube ......................................... SUCCESS [5:06.032s]
> [INFO] Lens DB storage ................................... SUCCESS [19.632s]
> [INFO] Lens Query Library ................................ SUCCESS [17.437s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s]
> [INFO] Lens Server ....................................... SUCCESS [6:10.729s]
> [INFO] Lens client ....................................... SUCCESS [38.716s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.862s]
> [INFO] Lens Examples ..................................... SUCCESS [10.414s]
> [INFO] Lens Distribution ................................. SUCCESS [8.630s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s]
> [INFO] Lens Regression ................................... SUCCESS [10.184s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:30.753s
> [INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015
> [INFO] Final Memory: 192M/1814M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99948
-----------------------------------------------------------
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java (line 52)
<https://reviews.apache.org/r/37346/#comment156992>
constant not used ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 183)
<https://reviews.apache.org/r/37346/#comment156993>
Does the private scope need change?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 470)
<https://reviews.apache.org/r/37346/#comment156996>
Result set may not available for all queries.
Should be check isResultAvailable check instead of catching exception and unnecessary for log ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 871)
<https://reviews.apache.org/r/37346/#comment156997>
Why is this required?
- Amareshwari Sriramadasu
On Sept. 22, 2015, 8:13 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 8:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/main/webapp/static/index.html 70aa6bf151b67fde9aaa8372f0fe3c164f1e786d
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s]
> [INFO] Lens .............................................. SUCCESS [3.146s]
> [INFO] Lens API .......................................... SUCCESS [21.540s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.002s]
> [INFO] Lens Cube ......................................... SUCCESS [5:06.032s]
> [INFO] Lens DB storage ................................... SUCCESS [19.632s]
> [INFO] Lens Query Library ................................ SUCCESS [17.437s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s]
> [INFO] Lens Server ....................................... SUCCESS [6:10.729s]
> [INFO] Lens client ....................................... SUCCESS [38.716s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.862s]
> [INFO] Lens Examples ..................................... SUCCESS [10.414s]
> [INFO] Lens Distribution ................................. SUCCESS [8.630s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s]
> [INFO] Lens Regression ................................... SUCCESS [10.184s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:30.753s
> [INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015
> [INFO] Final Memory: 192M/1814M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99955
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 789)
<https://reviews.apache.org/r/37346/#comment157006>
Taking care of LENS-783 here.
- Rajat Khandelwal
On Sept. 22, 2015, 2:55 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 2:55 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include:
>
> 1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
> 1. if the query failed, it's purgable
> 2. if the query doesn't have a result, it's purgable
> 3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
> 1. If the result is persistent, it's purgable
> 2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
> 1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
> 2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
>
>
> 2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
> 3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
> 4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query.
> 6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
> 10. Added Test cases for query purging.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.828s]
> [INFO] Lens .............................................. SUCCESS [2.893s]
> [INFO] Lens API .......................................... SUCCESS [22.171s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.408s]
> [INFO] Lens Cube ......................................... SUCCESS [5:06.448s]
> [INFO] Lens DB storage ................................... SUCCESS [22.723s]
> [INFO] Lens Query Library ................................ SUCCESS [17.844s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:23.430s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [41.430s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [22.646s]
> [INFO] Lens Server ....................................... SUCCESS [8:01.584s]
> [INFO] Lens client ....................................... SUCCESS [37.284s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.185s]
> [INFO] Lens Examples ..................................... SUCCESS [9.901s]
> [INFO] Lens Distribution ................................. SUCCESS [8.453s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.537s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.206s]
> [INFO] Lens Regression ................................... SUCCESS [10.486s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:08.364s
> [INFO] Finished at: Tue Sep 22 08:33:26 UTC 2015
> [INFO] Final Memory: 184M/1305M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 22, 2015, 10:23 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java, line 779
> > <https://reviews.apache.org/r/37346/diff/9/?file=1080331#file1080331line779>
> >
> > Let us change the name to lens.server.query.purger.interval
If the name is lens.server.query.purge.interval, it seems it is still linked to single query. Instead shall we rename it to lens.server.querypurger.sleep.interval ? Please update apt file as well.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99966
-----------------------------------------------------------
On Sept. 22, 2015, 2:46 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 2:46 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include:
>
> 1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
> 1. if the query failed, it's purgable
> 2. if the query doesn't have a result, it's purgable
> 3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
> 1. If the result is persistent, it's purgable
> 2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
> 1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
> 2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
>
>
> 2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
> 3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
> 4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query.
> 6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
> 10. Added Test cases for query purging.
> 11. The way we're taking care of purge happening before event handlers are done with context is by utilizing garbage collection. We pass context to the QueryEnded event object. Now whenever the event happens, it has access to the context. It has access even when purger has purged the query(since the object will only go obsolete if no one has a handle to it). In purging, the context is removed from various query collections, but context object is intact. Whenever all event handlers for the QueryEnded event are done, both the event object and the query context object will be garbage collected.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java bc0465c782a86d484747f0375135191bef0c49d1
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java ea8f70fc54b7c646e982a4de882eea92124b73d5
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 3e9474c642827e401a1e243ae25d328557f1adc0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 40a1c0f1078c82f882eab60a0f0b20b501789da5
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QuerySuccess.java c551dbab463dc7dd199f4fa1c6c56c956f56a704
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java b57bc640bee018c2b7da560c2c4bcad5e228d41a
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java b8012be1c30b544e51228c4b9b8a2a7d8281d3bc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.844s]
> [INFO] Lens .............................................. SUCCESS [3.076s]
> [INFO] Lens API .......................................... SUCCESS [21.253s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.861s]
> [INFO] Lens Cube ......................................... SUCCESS [5:08.507s]
> [INFO] Lens DB storage ................................... SUCCESS [19.065s]
> [INFO] Lens Query Library ................................ SUCCESS [15.206s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.257s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.338s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.467s]
> [INFO] Lens Server ....................................... SUCCESS [8:52.207s]
> [INFO] Lens client ....................................... SUCCESS [38.217s]
> [INFO] Lens CLI .......................................... SUCCESS [2:45.810s]
> [INFO] Lens Examples ..................................... SUCCESS [10.357s]
> [INFO] Lens Distribution ................................. SUCCESS [8.390s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:22.195s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.081s]
> [INFO] Lens Regression ................................... SUCCESS [11.032s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:25.067s
> [INFO] Finished at: Tue Sep 22 14:20:49 UTC 2015
> [INFO] Final Memory: 186M/1378M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review99966
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 779)
<https://reviews.apache.org/r/37346/#comment157016>
Let us change the name to lens.server.query.purger.interval
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java (line 60)
<https://reviews.apache.org/r/37346/#comment157017>
Let us make this abstract
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 875)
<https://reviews.apache.org/r/37346/#comment157020>
seems variables got exchanged
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 903)
<https://reviews.apache.org/r/37346/#comment157025>
If we are purging immediately, please take care of StatsUpdater also.
- Amareshwari Sriramadasu
On Sept. 22, 2015, 9:25 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 9:25 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include:
>
> 1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
> 1. if the query failed, it's purgable
> 2. if the query doesn't have a result, it's purgable
> 3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
> 1. If the result is persistent, it's purgable
> 2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
> 1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
> 2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
>
>
> 2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
> 3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
> 4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query.
> 6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
> 10. Added Test cases for query purging.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.828s]
> [INFO] Lens .............................................. SUCCESS [2.893s]
> [INFO] Lens API .......................................... SUCCESS [22.171s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.408s]
> [INFO] Lens Cube ......................................... SUCCESS [5:06.448s]
> [INFO] Lens DB storage ................................... SUCCESS [22.723s]
> [INFO] Lens Query Library ................................ SUCCESS [17.844s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:23.430s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [41.430s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [22.646s]
> [INFO] Lens Server ....................................... SUCCESS [8:01.584s]
> [INFO] Lens client ....................................... SUCCESS [37.284s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.185s]
> [INFO] Lens Examples ..................................... SUCCESS [9.901s]
> [INFO] Lens Distribution ................................. SUCCESS [8.453s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.537s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.206s]
> [INFO] Lens Regression ................................... SUCCESS [10.486s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:08.364s
> [INFO] Finished at: Tue Sep 22 08:33:26 UTC 2015
> [INFO] Final Memory: 184M/1305M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review100149
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Sept. 23, 2015, 6:29 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 6:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include:
>
> 1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
> 1. if the query failed, it's purgable
> 2. if the query doesn't have a result, it's purgable
> 3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
> 1. If the result is persistent, it's purgable
> 2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
> 1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
> 2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
>
>
> 2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
> 3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
> 4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
> 5. `instanceof` Checks have been converted to polymorphism:
> 1. For http result set availability.
> 2. For forming email message of the result of a finished query.
> 6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
> 7. Taking care of LENS-783
> 8. Modularizing testing of email notifications
> 9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
> 10. Added Test cases for query purging.
> 11. The way we're taking care of purge happening before event handlers are done with context is by utilizing garbage collection. We pass context to the QueryEnded event object. Now whenever the event happens, it has access to the context. It has access even when purger has purged the query(since the object will only go obsolete if no one has a handle to it). In purging, the context is removed from various query collections, but context object is intact. Whenever all event handlers for the QueryEnded event are done, both the event object and the query context object will be garbage collected.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java bc0465c782a86d484747f0375135191bef0c49d1
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java ea8f70fc54b7c646e982a4de882eea92124b73d5
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 3e9474c642827e401a1e243ae25d328557f1adc0
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 40a1c0f1078c82f882eab60a0f0b20b501789da5
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QuerySuccess.java c551dbab463dc7dd199f4fa1c6c56c956f56a704
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java b57bc640bee018c2b7da560c2c4bcad5e228d41a
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java b8012be1c30b544e51228c4b9b8a2a7d8281d3bc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
> lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
> src/site/apt/admin/config.apt 3500441bd395b8c18dabe3ce0fa912eaeaa67b27
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.844s]
> [INFO] Lens .............................................. SUCCESS [3.076s]
> [INFO] Lens API .......................................... SUCCESS [21.253s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.861s]
> [INFO] Lens Cube ......................................... SUCCESS [5:08.507s]
> [INFO] Lens DB storage ................................... SUCCESS [19.065s]
> [INFO] Lens Query Library ................................ SUCCESS [15.206s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.257s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.338s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.467s]
> [INFO] Lens Server ....................................... SUCCESS [8:52.207s]
> [INFO] Lens client ....................................... SUCCESS [38.217s]
> [INFO] Lens CLI .......................................... SUCCESS [2:45.810s]
> [INFO] Lens Examples ..................................... SUCCESS [10.357s]
> [INFO] Lens Distribution ................................. SUCCESS [8.390s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:22.195s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.081s]
> [INFO] Lens Regression ................................... SUCCESS [11.032s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:25.067s
> [INFO] Finished at: Tue Sep 22 14:20:49 UTC 2015
> [INFO] Final Memory: 186M/1378M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 11:59 a.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Changes include:
1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
1. if the query failed, it's purgable
2. if the query doesn't have a result, it's purgable
3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
1. If the result is persistent, it's purgable
2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
5. `instanceof` Checks have been converted to polymorphism:
1. For http result set availability.
2. For forming email message of the result of a finished query.
6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
7. Taking care of LENS-783
8. Modularizing testing of email notifications
9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
10. Added Test cases for query purging.
11. The way we're taking care of purge happening before event handlers are done with context is by utilizing garbage collection. We pass context to the QueryEnded event object. Now whenever the event happens, it has access to the context. It has access even when purger has purged the query(since the object will only go obsolete if no one has a handle to it). In purging, the context is removed from various query collections, but context object is intact. Whenever all event handlers for the QueryEnded event are done, both the event object and the query context object will be garbage collected.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java bc0465c782a86d484747f0375135191bef0c49d1
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java ea8f70fc54b7c646e982a4de882eea92124b73d5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 3e9474c642827e401a1e243ae25d328557f1adc0
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 40a1c0f1078c82f882eab60a0f0b20b501789da5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QuerySuccess.java c551dbab463dc7dd199f4fa1c6c56c956f56a704
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java b57bc640bee018c2b7da560c2c4bcad5e228d41a
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java b8012be1c30b544e51228c4b9b8a2a7d8281d3bc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
src/site/apt/admin/config.apt 3500441bd395b8c18dabe3ce0fa912eaeaa67b27
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.844s]
[INFO] Lens .............................................. SUCCESS [3.076s]
[INFO] Lens API .......................................... SUCCESS [21.253s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.861s]
[INFO] Lens Cube ......................................... SUCCESS [5:08.507s]
[INFO] Lens DB storage ................................... SUCCESS [19.065s]
[INFO] Lens Query Library ................................ SUCCESS [15.206s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.257s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.338s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.467s]
[INFO] Lens Server ....................................... SUCCESS [8:52.207s]
[INFO] Lens client ....................................... SUCCESS [38.217s]
[INFO] Lens CLI .......................................... SUCCESS [2:45.810s]
[INFO] Lens Examples ..................................... SUCCESS [10.357s]
[INFO] Lens Distribution ................................. SUCCESS [8.390s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.195s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.081s]
[INFO] Lens Regression ................................... SUCCESS [11.032s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:25.067s
[INFO] Finished at: Tue Sep 22 14:20:49 UTC 2015
[INFO] Final Memory: 186M/1378M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 8:16 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Changes include:
1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
1. if the query failed, it's purgable
2. if the query doesn't have a result, it's purgable
3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
1. If the result is persistent, it's purgable
2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
5. `instanceof` Checks have been converted to polymorphism:
1. For http result set availability.
2. For forming email message of the result of a finished query.
6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
7. Taking care of LENS-783
8. Modularizing testing of email notifications
9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
10. Added Test cases for query purging.
11. The way we're taking care of purge happening before event handlers are done with context is by utilizing garbage collection. We pass context to the QueryEnded event object. Now whenever the event happens, it has access to the context. It has access even when purger has purged the query(since the object will only go obsolete if no one has a handle to it). In purging, the context is removed from various query collections, but context object is intact. Whenever all event handlers for the QueryEnded event are done, both the event object and the query context object will be garbage collected.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java bc0465c782a86d484747f0375135191bef0c49d1
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java ea8f70fc54b7c646e982a4de882eea92124b73d5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 3e9474c642827e401a1e243ae25d328557f1adc0
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 40a1c0f1078c82f882eab60a0f0b20b501789da5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QuerySuccess.java c551dbab463dc7dd199f4fa1c6c56c956f56a704
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java b57bc640bee018c2b7da560c2c4bcad5e228d41a
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java b8012be1c30b544e51228c4b9b8a2a7d8281d3bc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.844s]
[INFO] Lens .............................................. SUCCESS [3.076s]
[INFO] Lens API .......................................... SUCCESS [21.253s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.861s]
[INFO] Lens Cube ......................................... SUCCESS [5:08.507s]
[INFO] Lens DB storage ................................... SUCCESS [19.065s]
[INFO] Lens Query Library ................................ SUCCESS [15.206s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.257s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.338s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.467s]
[INFO] Lens Server ....................................... SUCCESS [8:52.207s]
[INFO] Lens client ....................................... SUCCESS [38.217s]
[INFO] Lens CLI .......................................... SUCCESS [2:45.810s]
[INFO] Lens Examples ..................................... SUCCESS [10.357s]
[INFO] Lens Distribution ................................. SUCCESS [8.390s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.195s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.081s]
[INFO] Lens Regression ................................... SUCCESS [11.032s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:25.067s
[INFO] Finished at: Tue Sep 22 14:20:49 UTC 2015
[INFO] Final Memory: 186M/1378M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 7:59 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description (updated)
-------
Changes include:
1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
1. if the query failed, it's purgable
2. if the query doesn't have a result, it's purgable
3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
1. If the result is persistent, it's purgable
2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
5. `instanceof` Checks have been converted to polymorphism:
1. For http result set availability.
2. For forming email message of the result of a finished query.
6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
7. Taking care of LENS-783
8. Modularizing testing of email notifications
9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
10. Added Test cases for query purging.
11. The way we're taking care of purge happening before event handlers are done with context is by utilizing garbage collection. We pass context to the QueryEnded event object. Now whenever the event happens, it has access to the context. It has access even when purger has purged the query(since the object will only go obsolete if no one has a handle to it). In purging, the context is removed from various query collections, but context object is intact. Whenever all event handlers for the QueryEnded event are done, both the event object and the query context object will be garbage collected.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 4536a18b1e631484a994c9d7a81e12f1f4e1147b
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java bc0465c782a86d484747f0375135191bef0c49d1
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java ea8f70fc54b7c646e982a4de882eea92124b73d5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 3e9474c642827e401a1e243ae25d328557f1adc0
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryFailed.java 40a1c0f1078c82f882eab60a0f0b20b501789da5
lens-server-api/src/main/java/org/apache/lens/server/api/query/QuerySuccess.java c551dbab463dc7dd199f4fa1c6c56c956f56a704
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java b57bc640bee018c2b7da560c2c4bcad5e228d41a
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java b8012be1c30b544e51228c4b9b8a2a7d8281d3bc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
Diff: https://reviews.apache.org/r/37346/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.844s]
[INFO] Lens .............................................. SUCCESS [3.076s]
[INFO] Lens API .......................................... SUCCESS [21.253s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.861s]
[INFO] Lens Cube ......................................... SUCCESS [5:08.507s]
[INFO] Lens DB storage ................................... SUCCESS [19.065s]
[INFO] Lens Query Library ................................ SUCCESS [15.206s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.257s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.338s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.467s]
[INFO] Lens Server ....................................... SUCCESS [8:52.207s]
[INFO] Lens client ....................................... SUCCESS [38.217s]
[INFO] Lens CLI .......................................... SUCCESS [2:45.810s]
[INFO] Lens Examples ..................................... SUCCESS [10.357s]
[INFO] Lens Distribution ................................. SUCCESS [8.390s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.195s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.081s]
[INFO] Lens Regression ................................... SUCCESS [11.032s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:25.067s
[INFO] Finished at: Tue Sep 22 14:20:49 UTC 2015
[INFO] Final Memory: 186M/1378M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 2:55 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description (updated)
-------
Changes include:
1. The configuration `lens.server.max.finished.queries` has been taken off. Now All queries are purged as soon as they are purgable. The logic of purgability of a query is that:
1. if the query failed, it's purgable
2. if the query doesn't have a result, it's purgable
3. If it has a result, then result class is asked whether it's purgable or not. This is the second layer of the logic. Current logic in that layer is as follows:
1. If the result is persistent, it's purgable
2. If the result is in memory, it's not purgable initially, but after all the rows have been accessed by someone, it becomes purgable. The rows can be accessed in the following ways:
1. While sending Email notification, in memory result is appended in the email. Hence rows are accessed.
2. Explicit call by a user for reading result set (/resultset REST API, but not the /httpresultset API, http results are not available for in memory results.)
2. There is a new configuration `lens.server.purge.interval`. The value is supposed to be in milliseconds. This is the frequency of purger thread.
3. Purger thread had a bug in which it had a queue of finished queries which were inserted according to their finish time. Purging of later queries was dependent on purging of earlier queries. If a later query becomes purgable, it's not purged untill all the queries before it become purgable and are purged. To fix this, purger thread now runs periodically and scans the whole queue, purges whichever ones are purgable.
4. FinishedLensQuery is a model object, but has a field which is not a field in corresponding database. That field is removed from equals check
5. `instanceof` Checks have been converted to polymorphism:
1. For http result set availability.
2. For forming email message of the result of a finished query.
6. Email notifications are now sent irrespective of whether the query has been purged or not. Earlier there was a bug that if a query is purged, email notification for that isn't sent.
7. Taking care of LENS-783
8. Modularizing testing of email notifications
9. Made more util methods in RestAPITestUtil which became re-usable in server tests like TestQueryService.
10. Added Test cases for query purging.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.828s]
[INFO] Lens .............................................. SUCCESS [2.893s]
[INFO] Lens API .......................................... SUCCESS [22.171s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.408s]
[INFO] Lens Cube ......................................... SUCCESS [5:06.448s]
[INFO] Lens DB storage ................................... SUCCESS [22.723s]
[INFO] Lens Query Library ................................ SUCCESS [17.844s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:23.430s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [41.430s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [22.646s]
[INFO] Lens Server ....................................... SUCCESS [8:01.584s]
[INFO] Lens client ....................................... SUCCESS [37.284s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.185s]
[INFO] Lens Examples ..................................... SUCCESS [9.901s]
[INFO] Lens Distribution ................................. SUCCESS [8.453s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.537s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.206s]
[INFO] Lens Regression ................................... SUCCESS [10.486s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:08.364s
[INFO] Finished at: Tue Sep 22 08:33:26 UTC 2015
[INFO] Final Memory: 184M/1305M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 2:23 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/main/webapp/static/index.html 70aa6bf151b67fde9aaa8372f0fe3c164f1e786d
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
Diff: https://reviews.apache.org/r/37346/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.828s]
[INFO] Lens .............................................. SUCCESS [2.893s]
[INFO] Lens API .......................................... SUCCESS [22.171s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.408s]
[INFO] Lens Cube ......................................... SUCCESS [5:06.448s]
[INFO] Lens DB storage ................................... SUCCESS [22.723s]
[INFO] Lens Query Library ................................ SUCCESS [17.844s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:23.430s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [41.430s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [22.646s]
[INFO] Lens Server ....................................... SUCCESS [8:01.584s]
[INFO] Lens client ....................................... SUCCESS [37.284s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.185s]
[INFO] Lens Examples ..................................... SUCCESS [9.901s]
[INFO] Lens Distribution ................................. SUCCESS [8.453s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.537s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.206s]
[INFO] Lens Regression ................................... SUCCESS [10.486s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:08.364s
[INFO] Finished at: Tue Sep 22 08:33:26 UTC 2015
[INFO] Final Memory: 184M/1305M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 1:43 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java af439ff58002b06e2631585d35dfe9754ce84d4e
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 3c8531feb40276e076622b32f15c2f3d7ee782b2
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 006eaedcd5cdf86b9aae6c4bbfcd92ba6c1df8ba
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 096d26ee669c7e8c30df134ac334877311c1812e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java d8c04dbdfdbf5309ef4ec6b07de27de33d2ff517
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 12de0a51b33a5ca09cd494f2ea842794b800f9e6
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e27dd427cd573f57b06a3c8157c49f723b54caf
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/main/resources/lensserver-default.xml 3c8fc09242bb3f873aa43630c9f386435f10c659
lens-server/src/main/webapp/static/index.html 70aa6bf151b67fde9aaa8372f0fe3c164f1e786d
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 05bd99f8819477c9560e231148b1e9ef7a8f061b
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fa8d6eed0b98e9debe5e1c6f138bb7b104dff135
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 98a658e9c02a9da9d6708e4db1df161c6ea1a784
lens-server/src/test/resources/lens-site.xml f728810867b677b6c7fba29229206eed1937e37f
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s]
[INFO] Lens .............................................. SUCCESS [3.146s]
[INFO] Lens API .......................................... SUCCESS [21.540s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.002s]
[INFO] Lens Cube ......................................... SUCCESS [5:06.032s]
[INFO] Lens DB storage ................................... SUCCESS [19.632s]
[INFO] Lens Query Library ................................ SUCCESS [17.437s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s]
[INFO] Lens Server ....................................... SUCCESS [6:10.729s]
[INFO] Lens client ....................................... SUCCESS [38.716s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.862s]
[INFO] Lens Examples ..................................... SUCCESS [10.414s]
[INFO] Lens Distribution ................................. SUCCESS [8.630s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s]
[INFO] Lens Regression ................................... SUCCESS [10.184s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:30.753s
[INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015
[INFO] Final Memory: 192M/1814M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 6:17 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa3ef3d111b5d1728f6df854623b9effbfb
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
Diff: https://reviews.apache.org/r/37346/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s]
[INFO] Lens .............................................. SUCCESS [3.146s]
[INFO] Lens API .......................................... SUCCESS [21.540s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.002s]
[INFO] Lens Cube ......................................... SUCCESS [5:06.032s]
[INFO] Lens DB storage ................................... SUCCESS [19.632s]
[INFO] Lens Query Library ................................ SUCCESS [17.437s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s]
[INFO] Lens Server ....................................... SUCCESS [6:10.729s]
[INFO] Lens client ....................................... SUCCESS [38.716s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.862s]
[INFO] Lens Examples ..................................... SUCCESS [10.414s]
[INFO] Lens Distribution ................................. SUCCESS [8.630s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s]
[INFO] Lens Regression ................................... SUCCESS [10.184s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:30.753s
[INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015
[INFO] Final Memory: 192M/1814M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review96669
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 490)
<https://reviews.apache.org/r/37346/#comment152292>
Should we purge immediately.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 794)
<https://reviews.apache.org/r/37346/#comment152295>
This update may not happen until next updateStatus is called.
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java (line 81)
<https://reviews.apache.org/r/37346/#comment152296>
Let us not move this here - as it would delay setting query as successful to get event raised and resultformatter setting this.
- Amareshwari Sriramadasu
On Aug. 27, 2015, 9:47 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 9:47 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b3f5d936fd4412d71d0a2cf19b8578bb919b2954
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 3:17 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b3f5d936fd4412d71d0a2cf19b8578bb919b2954
Diff: https://reviews.apache.org/r/37346/diff/
Testing (updated)
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 27, 2015, 3:16 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/LensConf.java, line 1
> > <https://reviews.apache.org/r/37346/diff/5/?file=1055811#file1055811line1>
> >
> > I'm hiting an infinite loop somewhere. Opening a dummy issue, will resolve when fixed.
Also, the infinite loop is intermittent. The build succeeds generally but in one corner case, there's an infinite loop.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review96662
-----------------------------------------------------------
On Aug. 27, 2015, 3:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 3:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b3f5d936fd4412d71d0a2cf19b8578bb919b2954
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review96662
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/LensConf.java (line 1)
<https://reviews.apache.org/r/37346/#comment152280>
I'm hiting an infinite loop somewhere. Opening a dummy issue, will resolve when fixed.
- Rajat Khandelwal
On Aug. 27, 2015, 12:44 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 12:44 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b3f5d936fd4412d71d0a2cf19b8578bb919b2954
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.921s]
> [INFO] Lens .............................................. SUCCESS [2.990s]
> [INFO] Lens API .......................................... SUCCESS [22.963s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.298s]
> [INFO] Lens Cube ......................................... SUCCESS [5:04.785s]
> [INFO] Lens DB storage ................................... SUCCESS [20.041s]
> [INFO] Lens Query Library ................................ SUCCESS [16.631s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:51.878s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.420s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.272s]
> [INFO] Lens Server ....................................... SUCCESS [6:42.986s]
> [INFO] Lens client ....................................... SUCCESS [36.265s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.089s]
> [INFO] Lens Examples ..................................... SUCCESS [10.041s]
> [INFO] Lens Distribution ................................. SUCCESS [8.469s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:25.623s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.882s]
> [INFO] Lens Regression ................................... SUCCESS [10.528s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:10.202s
> [INFO] Finished at: Thu Aug 27 07:08:35 UTC 2015
> [INFO] Final Memory: 193M/2022M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 12:44 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b3f5d936fd4412d71d0a2cf19b8578bb919b2954
Diff: https://reviews.apache.org/r/37346/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.921s]
[INFO] Lens .............................................. SUCCESS [2.990s]
[INFO] Lens API .......................................... SUCCESS [22.963s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.298s]
[INFO] Lens Cube ......................................... SUCCESS [5:04.785s]
[INFO] Lens DB storage ................................... SUCCESS [20.041s]
[INFO] Lens Query Library ................................ SUCCESS [16.631s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:51.878s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.420s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.272s]
[INFO] Lens Server ....................................... SUCCESS [6:42.986s]
[INFO] Lens client ....................................... SUCCESS [36.265s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.089s]
[INFO] Lens Examples ..................................... SUCCESS [10.041s]
[INFO] Lens Distribution ................................. SUCCESS [8.469s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:25.623s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.882s]
[INFO] Lens Regression ................................... SUCCESS [10.528s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:10.202s
[INFO] Finished at: Thu Aug 27 07:08:35 UTC 2015
[INFO] Final Memory: 193M/2022M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/#review96493
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 21, 2015, 12:51 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37346/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 12:51 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-693
> https://issues.apache.org/jira/browse/LENS-693
>
>
> Repository: lens
>
>
> Description
> -------
>
> Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
>
> Did some refactoring in order to use inheritence instead of instanceof.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
> lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
> lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
> lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
>
> Diff: https://reviews.apache.org/r/37346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 21, 2015, 6:21 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 21, 2015, 5:47 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description (updated)
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB.
Did some refactoring in order to use inheritence instead of instanceof.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 3b1ad87ffe16b572437b92d90c793ea1881c2e0d
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java a2e10c6560aaa551a15408b2937c3d495b51af5f
lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java 3ecf0c229494dd82a531bc5a310e3b056a86d451
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 00e1e53444ca76fa5096efc69fc4bdfdd16d116a
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java 929a3026da9d9789b64ab1f04fdd063db3443432
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java bbde1705fec7fb946708b17d57eb5ad74fcb7cef
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b28669e9070578e5121eb4b1c59e8e3ac7cb83de
lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java b65a5f4ac661f060b51d5ee1c899dfd93aa8be90
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0945598eed81515702402e9933b2592186209508
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 82ce205c8d54c6665262ee3baf8c521203743eb5
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37346: LENS-693: Query Result Mail is not working
when finishedQueries is set to zero
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37346/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 3:26 p.m.)
Review request for lens.
Bugs: LENS-693
https://issues.apache.org/jira/browse/LENS-693
Repository: lens
Description
-------
Query Result Mail is not working when finished queries is set to zero as the queries are immediately going to the DB
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java 6a9f4558afc3a8430b43dcc65d73c813575a334d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 7a5b177538e4a8c946422ff905c6c048d828b6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 31c343a7b72c13ff9eb9b01038574297629e381b
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 78b3320977f9b46b2719ba80190fa77e87ecc729
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 3b761268645acf150d149e51f69521bf164c61ee
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c29a1ac4be7c44c13e3d1e964b18c240adb61d5f
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java af42eb06e2c030a7040b970e982cab782b2bb251
Diff: https://reviews.apache.org/r/37346/diff/
Testing
-------
Thanks,
Rajat Khandelwal