You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/09 07:08:40 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
zuston opened a new pull request, #208:
URL: https://github.com/apache/incubator-uniffle/pull/208
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Use the conf of shuffleNodesNumber from jobs to be as checking factor
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
In the PR #97 , it allow client to specify the shuffle server numbers, but in clusterLoaderChecker, it dont take this into considering. In this PR, it will use the conf of shuffleNodesNumber from jobs to be as checking factor only when the conf of `rss.coordinator.access.loadChecker.serverNum.threshold` is missed.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
UTs.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246238789
> Should we give a option of coordinator to decide whether to use the required shuffle server of client for users?
Not necessary. If the conf value of `rss.client.assignment.shuffle.nodes.max` is -1 or not set, it will use the conf from coordinator side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1251766832
Thanks for your patient review @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1250864266
Should we add more documents for this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#discussion_r967658203
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -99,13 +103,17 @@ private boolean tryAccessCluster() {
long retryInterval = sparkConf.get(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS);
int retryTimes = sparkConf.get(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES);
+ int assignmentShuffleNodesNum = sparkConf.get(RssSparkConfig.RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER);
Review Comment:
Why do we only modify spark3?
##########
common/src/main/java/org/apache/uniffle/common/util/Constants.java:
##########
@@ -43,4 +43,6 @@ public class Constants {
public static final String CONF_REMOTE_STORAGE_PATH = ".remote.storage.path";
public static final String RSS_CLIENT_CONF_REMOTE_STORAGE_PATH =
RSS_CLIENT_CONF_COMMON_PREFIX + CONF_REMOTE_STORAGE_PATH;
+
+ public static final String ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM = "access_info_required_shuffle_nodes_num";
Review Comment:
Why do we need this config option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246200786
Got your thought.
But the conf of `rss.coordinator.access.loadChecker.serverNum.threshold` is a hard limitation, if value is too low, it will pass all. If too high, it will reject all.
For the equality of every job, I wont set it and hope the checker can decide whether to reject depending on the required shuffle servers number of jobs.
I thinks this is reasonable, it will still reserve the hard limitation and keep the flexibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#discussion_r967662677
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -99,13 +103,17 @@ private boolean tryAccessCluster() {
long retryInterval = sparkConf.get(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS);
int retryTimes = sparkConf.get(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES);
+ int assignmentShuffleNodesNum = sparkConf.get(RssSparkConfig.RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER);
Review Comment:
Sorry, I forgot to modify in spark2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#discussion_r967662609
##########
common/src/main/java/org/apache/uniffle/common/util/Constants.java:
##########
@@ -43,4 +43,6 @@ public class Constants {
public static final String CONF_REMOTE_STORAGE_PATH = ".remote.storage.path";
public static final String RSS_CLIENT_CONF_REMOTE_STORAGE_PATH =
RSS_CLIENT_CONF_COMMON_PREFIX + CONF_REMOTE_STORAGE_PATH;
+
+ public static final String ACCESS_INFO_REQUIRED_SHUFFLE_NODES_NUM = "access_info_required_shuffle_nodes_num";
Review Comment:
The key is the indicator of the required shuffle node number in the access info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246587128
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1250890536
> Should we add more documents for this feature?
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1241635632
PTAL @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246182356
> You mean we should remove the check of `rss.coordinator.shuffle.nodes.max` in `AccessClusterLoadChecker`?
Origin logic don't check `rss.coordinator.shuffle.nodes.max`. It's a config option `rss.coordinator.access.loadChecker.serverNum.threshold`. Its default value is `rss.coordinator.shuffle.nodes.max`. Default value don't need to be reasonable for every situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246726435
> Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok?
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1245020376
> The conf of `rss.coordinator.shuffle.nodes.max` in coordinator is a soft limitation. It means when available nodes number is lower than this value, it will not throw exception and reassign the number of all available nodes.
>
> But in current implementation of `AccessClusterLoadChecker`, it will reject the app when available nodes number < `rss.coordinator.shuffle.nodes.max`.
>
> ### For example
> available shuffle nodes number = 20 job required shuffle nodes number = 10 `rss.coordinator.shuffle.nodes.max` = 30
>
> The `AccessClusterLoadChecker` will reject this job. I think this is unreasonable.
I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1245121664
You mean we should remove the check of `rss.coordinator.shuffle.nodes.max` in `AccessClusterLoadChecker`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1245028309
But the `rss.coordinator.shuffle.nodes.max` is just the default value. If you have other need, you can change this default value. `rss.coordinator.access.loadChecker.serverNum.threshold` isn't related the to `rss.coordinator.shuffle.nodes.max` actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1241611120
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#208](https://codecov.io/gh/apache/incubator-uniffle/pull/208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8f7ce1) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/9b83f66174911c88384bad325cb399cba25ab7d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b83f66) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #208 +/- ##
============================================
+ Coverage 59.02% 59.07% +0.04%
- Complexity 1326 1332 +6
============================================
Files 160 160
Lines 8699 8706 +7
Branches 815 818 +3
============================================
+ Hits 5135 5143 +8
+ Misses 3301 3300 -1
Partials 263 263
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/uniffle/common/util/Constants.java](https://codecov.io/gh/apache/incubator-uniffle/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi91dGlsL0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
| [.../uniffle/coordinator/AccessClusterLoadChecker.java](https://codecov.io/gh/apache/incubator-uniffle/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQWNjZXNzQ2x1c3RlckxvYWRDaGVja2VyLmphdmE=) | `96.96% <100.00%> (+0.81%)` | :arrow_up: |
| [...ava/org/apache/uniffle/coordinator/AccessInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQWNjZXNzSW5mby5qYXZh) | `90.90% <0.00%> (+9.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246203066
> Got your thought.
>
> But the conf of `rss.coordinator.access.loadChecker.serverNum.threshold` is a hard limitation, if value is too low, it will pass all. If too high, it will reject all.
>
> For the equality of every job, I wont set it and hope the checker can decide whether to reject depending on the required shuffle servers number of jobs.
>
> I thinks this is reasonable, it will still reserve the hard limitation and keep the flexibility
Should we give a option of coordinator to decide whether to use the required shuffle server of client for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246430584
> > Should we give a option of coordinator to decide whether to use the required shuffle server of client for users?
>
> Not necessary. If the conf value of `rss.client.assignment.shuffle.nodes.max` is -1 or not set, it will use the conf from coordinator side.
If I want to use `rss.coordinator.access.loadChecker.serverNum.threshold`, it's weird that we must guarantee that the conf value of `rss.client.assignment.shuffle.nodes.max` is -1 or not set. They are not related config options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1246452163
>
Oh. Sorry for not explaining clearly.
1. If the `rss.coordinator.access.loadChecker.serverNum.threshold` is set, this checker will only use this value as the checking condition.
2. If the `rss.coordinator.access.loadChecker.serverNum.threshold` is missing, this checker will use the client's shuffle-servers number as checking condition. If the value of `ss.client.assignment.shuffle.nodes.max is -1 or not set`, then it will fallback to use the coodinator side's `rss.coordinator.shuffle.nodes.max`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1244868508
The conf of `rss.coordinator.shuffle.nodes.max` in coordinator is a soft limitation. It means when available nodes number is lower than this value, it will not throw exception and reassign the number of all available nodes.
But in current implementation of `AccessClusterLoadChecker`, it will reject the app when available nodes number < `rss.coordinator.shuffle.nodes.max`.
### For example
available shuffle nodes number = 20
job required shuffle nodes number = 10
`rss.coordinator.shuffle.nodes.max` = 30
The `AccessClusterLoadChecker` will reject this job. I think this is unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1250693262
Ping @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #208: Use the conf of shuffleNodesNumber from jobs to be as checking factor
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #208:
URL: https://github.com/apache/incubator-uniffle/pull/208#issuecomment-1244824359
`RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER` means that the max number should be allocated for client. It's not min number that should be allocated for client. I think it's not suitable to judge whether to reject the application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org