You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/01 16:38:00 UTC
[jira] [Work logged] (BEAM-9026) ValueProviderTests test failures
[ https://issues.apache.org/jira/browse/BEAM-9026?focusedWorklogId=493582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493582 ]
ASF GitHub Bot logged work on BEAM-9026:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 16:37
Start Date: 01/Oct/20 16:37
Worklog Time Spent: 10m
Work Description: ibzib opened a new pull request #12989:
URL: https://github.com/apache/beam/pull/12989
This doesn't address the root cause of this issue, which is that value provider arguments are still leaking into unrelated tests.
R: @udim @tvalentyn
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 493582)
Time Spent: 1h 20m (was: 1h 10m)
> ValueProviderTests test failures
> --------------------------------
>
> Key: BEAM-9026
> URL: https://issues.apache.org/jira/browse/BEAM-9026
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, test-failures
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: P2
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It seems that there's an ordering issue with these tests, where they expect RuntimeValueProvider.runtime_options to be None, but it has already been initialized by another test.
> {code}
> 13:49:31 ______ ValueProviderTests.test_runtime_value_provider_positional_argument ______
> 13:49:31 [gw1] linux -- Python 3.6.8 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py36/build/srcs/sdks/python/target/.tox-py36-gcp-pytest/py36-gcp-pytest/bin/python
> 13:49:31
> 13:49:31 self = <apache_beam.options.value_provider_test.ValueProviderTests testMethod=test_runtime_value_provider_positional_argument>
> 13:49:31
> 13:49:31 def test_runtime_value_provider_positional_argument(self):
> 13:49:31 class UserDefinedOptions(PipelineOptions):
> 13:49:31 @classmethod
> 13:49:31 def _add_argparse_args(cls, parser):
> 13:49:31 parser.add_value_provider_argument(
> 13:49:31 'vpt_vp_arg4',
> 13:49:31 help='This positional argument is a value provider')
> 13:49:31 options = UserDefinedOptions([])
> 13:49:31 self.assertTrue(isinstance(options.vpt_vp_arg4, RuntimeValueProvider))
> 13:49:31 > self.assertFalse(options.vpt_vp_arg4.is_accessible())
> 13:49:31 E AssertionError: True is not false
> 13:49:31
> 13:49:31 apache_beam/options/value_provider_test.py:85: AssertionError
> 13:49:31 __________________ ValueProviderTests.test_set_runtime_option __________________
> 13:49:31 [gw1] linux -- Python 3.6.8 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py36/build/srcs/sdks/python/target/.tox-py36-gcp-pytest/py36-gcp-pytest/bin/python
> 13:49:31
> 13:49:31 self = <apache_beam.options.value_provider_test.ValueProviderTests testMethod=test_set_runtime_option>
> 13:49:31
> 13:49:31 def test_set_runtime_option(self):
> 13:49:31 # define ValueProvider options, with and without default values
> 13:49:31 class UserDefinedOptions1(PipelineOptions):
> 13:49:31 @classmethod
> 13:49:31 def _add_argparse_args(cls, parser):
> 13:49:31 parser.add_value_provider_argument(
> 13:49:31 '--vpt_vp_arg6',
> 13:49:31 help='This keyword argument is a value provider') # set at runtime
> 13:49:31
> 13:49:31 parser.add_value_provider_argument( # not set, had default int
> 13:49:31 '-v', '--vpt_vp_arg7', # with short form
> 13:49:31 default=123,
> 13:49:31 type=int)
> 13:49:31
> 13:49:31 parser.add_value_provider_argument( # not set, had default str
> 13:49:31 '--vpt_vp-arg8', # with dash in name
> 13:49:31 default='123',
> 13:49:31 type=str)
> 13:49:31
> 13:49:31 parser.add_value_provider_argument( # not set and no default
> 13:49:31 '--vpt_vp_arg9',
> 13:49:31 type=float)
> 13:49:31
> 13:49:31 parser.add_value_provider_argument( # positional argument set
> 13:49:31 'vpt_vp_arg10', # default & runtime ignored
> 13:49:31 help='This positional argument is a value provider',
> 13:49:31 type=float,
> 13:49:31 default=5.4)
> 13:49:31
> 13:49:31 # provide values at graph-construction time
> 13:49:31 # (options not provided here become of the type RuntimeValueProvider)
> 13:49:31 options = UserDefinedOptions1(['1.2'])
> 13:49:31 > self.assertFalse(options.vpt_vp_arg6.is_accessible())
> 13:49:31 E AssertionError: True is not false
> 13:49:31
> 13:49:31 apache_beam/options/value_provider_test.py:135: AssertionError
> {code}
> https://builds.apache.org/job/beam_PreCommit_Python_Commit/10566/timestamps/?time=HH:mm:ss&timeZone=GMT-8&appendLog&locale=en_US
--
This message was sent by Atlassian Jira
(v8.3.4#803005)