You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by iraghumitra <gi...@git.apache.org> on 2016/06/08 22:38:30 UTC
[GitHub] incubator-metron pull request #147: METRON-208 Add Google Analytics tags to ...
GitHub user iraghumitra opened a pull request:
https://github.com/apache/incubator-metron/pull/147
METRON-208 Add Google Analytics tags to Metron Home Pages
-Added Google Analytics support to Metron website
-Added screen text for few sections in the docs and community pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iraghumitra/incubator-metron METRON-208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #147
----
commit b51d451815c77a662629dd7dce3ba9e6c1d49404
Author: raghumitraksv <ra...@gmail.com>
Date: 2016-06-08T22:24:07Z
METRON-208 Add Google Analytics tags to Metron Home Pages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/147
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by iraghumitra <gi...@git.apache.org>.
Github user iraghumitra commented on the issue:
https://github.com/apache/incubator-metron/pull/147
Corrected apache id of Ryan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/147
(Also commented on METRON-173, but including here since this PR is currently open)
Ran the local jekyll server for the site - everything looks great. I am still seeing a number of missing file references show up in the logs while browsing, e.g.:
```
ERROR `/images/footer-overlay-bg.jpg' not found.
ERROR `/images/close-icon.png' not found.
ERROR `/wp-content/themes/hortonworks/images/overlay-close.png' not found.
ERROR `/wp-content/themes/hortonworks/images/logo1.png' not found.
ERROR `/images/loader1.gif' not found.
ERROR `/images/footer-overlay-bg.jpg' not found.
ERROR `/images/close-icon.png' not found.
ERROR `/wp-content/themes/hortonworks/images/overlay-close.png' not found.
ERROR `/wp-content/themes/hortonworks/images/logo1.png' not found.
ERROR `/images/loader1.gif' not found.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #147: METRON-208 Add Google Analytics tags to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/147
My apache id is incorrect. After @iraghumitra makes the change +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by iraghumitra <gi...@git.apache.org>.
Github user iraghumitra commented on the issue:
https://github.com/apache/incubator-metron/pull/147
Corrected Ryan's apache id
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #147: METRON-208 Add Google Analytics tags to ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/147#discussion_r66463687
--- Diff: site/diff ---
@@ -0,0 +1,186 @@
+diff --git a/site/_includes/footer.html b/site/_includes/footer.html
--- End diff --
Did this file get committed accidentally? Probably don't want the diff here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #147: METRON-208 Add Google Analytics tags to Metron ...
Posted by iraghumitra <gi...@git.apache.org>.
Github user iraghumitra commented on the issue:
https://github.com/apache/incubator-metron/pull/147
-Removed the diff file that accidentally got in
-Removed all the unused imports as they were throwing bunch of errors
-Added Ryan as PMC in contributors page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---