You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/29 19:23:22 UTC

[GitHub] [airflow] khalidmammadov commented on pull request #18590: Fixing bug when roles list is empty

khalidmammadov commented on pull request #18590:
URL: https://github.com/apache/airflow/pull/18590#issuecomment-930474988


   You are right, it's not even allowed to create a user without a role. In fact code will fail with KeyNotFound error as there is a  check for valid role names  above of that code and that accesses "roles" field optimistically.
   So, I think best thing would be to move this "required" field check block further up and just after "for" so it fails fast when they are not provided. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org