You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/06/27 20:55:17 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #726: ORC-691: Remove unused Snapcraft-related code

dongjoon-hyun opened a new pull request #726:
URL: https://github.com/apache/orc/pull/726


   ### What changes were proposed in this pull request?
   
   This PR aims to remove unused `Snapcraft`-related code from Apache ORC repository at Apache ORC 1.8.0.
   
   ### Why are the changes needed?
   
   The last release was Apache ORC 1.5.2 on `7 August 2018`. We had better remove this from Apache ORC repo and Snapstore officially to reduce the confusion.
   - https://snapcraft.io/orc
   
   ### How was this patch tested?
   
   N/A (This is a removal of unused code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869829969


   Thank you, @williamhyun and @wgtmac . 
   Since this PR only removes our unused code base, I'll merge this PR to `main` for Apache ORC 1.8.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869353921


   Thank you for review. Ya, I'm also wondering if that is used until now, @wgtmac . 
   
   @omalley may be able to get some statistics as the owner of that Snapcraft store.
   
   BTW, it's already not supported for three years (August 2018). To be safe, we may just want to remove this from our repo and keep `Snapcraft` store AS-IS status without any change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869222580


   Hi, @omalley , @wgtmac , @pgaref , @williamhyun . WDYT about this removal?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869333840


   Just curious if we can get the user activity from snapcraft. If it is rarely used there, we are confident to deprecate the support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #726:
URL: https://github.com/apache/orc/pull/726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869829969


   Thank you, @williamhyun and @wgtmac . 
   Since this PR only removes our unused code base, I'll merge this PR to `main` for Apache ORC 1.8.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869353921


   Thank you for review. Ya, I'm also wondering if that is used until now, @wgtmac . 
   
   @omalley may get some statistics as the owner of that Snapcraft store.
   
   BTW, it's already not supported for three years (August 2018). To be safe, we may just want to remove this from our repo and keep `Snapcraft` store AS-IS status without any change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869298034


   Thank you, @williamhyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #726:
URL: https://github.com/apache/orc/pull/726#issuecomment-869269147


   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #726: ORC-691: Remove unused Snapcraft-related code

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #726:
URL: https://github.com/apache/orc/pull/726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org