You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by jasdeep-hundal <no...@github.com> on 2014/04/09 00:32:50 UTC
[jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
See: https://issues.apache.org/jira/browse/JCLOUDS-526
You can merge this Pull Request by running:
git pull https://github.com/jasdeep-hundal/jclouds remove_nova_quotaclass
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/340
-- Commit Summary --
* Remove Nova QuotaClassApi
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaApi.java (8)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaAsyncApi.java (8)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/config/NovaRestClientModule.java (3)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/QuotaClass.java (62)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaClassApi.java (51)
D apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaClassAsyncApi.java (78)
D apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaClassApiExpectTest.java (105)
D apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaClassApiLiveTest.java (73)
D apis/openstack-nova/src/test/resources/quota_class.json (15)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/340.patch
https://github.com/jclouds/jclouds/pull/340.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Jeremy Daggett <no...@github.com>.
@demobox @everett-toews @zack-shoylev The `QuotaClassApi` looks to have been removed and integrated into the `os-quota-sets` API:
http://api.openstack.org/api-ref-compute-v2-ext.html#ext-os-quota-sets
My feeling right now is that we can remove this API, with the understanding that we add support for the new `os-quota-sets` API.
In general the OpenStack extension mechanism needs some attention so that Nova, Keystone and Neutron use common extension code. Its been on my mind for a while, so I will create a JIRA to address both of these issues.
cc @jasdeep-hundal
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40750078
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1208](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1208/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39914310
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #739](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/739/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39915914
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1235](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1235/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40856480
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1005](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1005/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39916946
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #740](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/740/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39918115
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1210](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1210/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39918285
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #765](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/765/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40856331
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Andrew Phillips <no...@github.com>.
Closed #340.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Andrew Phillips <no...@github.com>.
Code change itself looks fine to me. I'll leave it up to @zack-shoylev, @everett-toews or @jdaggett to comment on the removal of the extension itself.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39914499
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by jasdeep-hundal <no...@github.com>.
@jdaggett @demobox : The os-quota-sets API actually already exists in JClouds separately: [QuotaAsyncApi.java](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaAsyncApi.java)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40755795
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by jasdeep-hundal <no...@github.com>.
@everett-toews (and others): Rebased after your +1 and retested, so should be good to go.
@jdaggett : Just to leave a note here, as we discussed earlier, going to hold off on those changes to QuotaApi until we settle a few things on how to handle changes between OpenStack releases.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40854871
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1209](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1209/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39916128
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1004](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1004/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39913655
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Jeremy Daggett <no...@github.com>.
@demobox My opinion is that the extension should be *removed*, but lets get input from @everett-toews and @zack-shoylev before deciding to remove it.
@jasdeep-hundal Oh, thanks, you are right! That wasn't apparent to me based on the API name!
>From the latest docs, the following fields appear to have been removed from the response: `volumes`, `gigabytes`, and `cores`. Several new fields have been added: `quota_set`, `fixed_ips`, and `injected_file_path_bytes`. The [Quota](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/Quota.java) class will need to reflect those changes.
Since `securityGroupRules` is optional, we would need to reflect that as `Optional<Integer>`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40772042
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Everett Toews <no...@github.com>.
+1 to removing the `QuotaClassApi` considering it never worked in OpenStack anyway.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40816182
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1039](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1039/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40858564
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=b2be1499460b49de85c20161c022cee86998a638). Thanks, @jasdeep-hundal!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40868874
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1006](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1006/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39919556
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by Andrew Phillips <no...@github.com>.
Thanks for looking into that, @jdaggett! Do you feel this PR should be reworked to _rename_ rather than _remove_ this extension, then?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-40752931
Re: [jclouds] JCLOUDS-526: Remove Nova QuotaClassApi (#340)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #738](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/738/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/340#issuecomment-39913943