You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/07/26 08:18:20 UTC
[GitHub] [systemds] paginabianca opened a new pull request, #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
paginabianca opened a new pull request, #1671:
URL: https://github.com/apache/systemds/pull/1671
Wrong datatype in switch statement caused index out of bounds with columns of type FP32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on PR #1671:
URL: https://github.com/apache/systemds/pull/1671#issuecomment-1219613332
Thanks for merging - @paginabianca encountered the related bug with a frame having FP32 columns in its mtd file and consuming it in transformencode. It might be nice to create a respective test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on PR #1671:
URL: https://github.com/apache/systemds/pull/1671#issuecomment-1220000817
We didn't encounter this issue in the local transformencode simply because we don't call getColumnData there.
In the encoders we access cell-wise (getDouble) and the objectToDouble method rightly handles FP32 @mboehm7.
Thanks @paginabianca for even fixing the getInMemorySize method. Not supporting FP32 there leads to wrong size calculation and in turn array out-of-bound error during serializing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] paginabianca closed pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
Posted by GitBox <gi...@apache.org>.
paginabianca closed pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
URL: https://github.com/apache/systemds/pull/1671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1671:
URL: https://github.com/apache/systemds/pull/1671#issuecomment-1218251340
Hi @paginabianca
Thanks for the PR. I will say that this is a minor change and it is not hooked up completely to the entire pipeline since we do no differentiate differentiate float previsions in the frame block yet, but thanks for the contribution.
I will merge shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1671: [MINOR] Fixes FrameBlock$FloatArray datatype.
URL: https://github.com/apache/systemds/pull/1671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org