[GitHub] flink pull request #5789: [FLINK-9103] Using CanonicalHostName instead of IP...

[EAlexRojas <gi...@git.apache.org>]

GitHub user EAlexRojas opened a pull request:

    https://github.com/apache/flink/pull/5789

    [FLINK-9103] Using CanonicalHostName instead of IP for SSL connection on NettyClient

    ## What is the purpose of the change
    
    This pull request makes the NettyClient use the CanonicalHostName instead of the IP address for SSL communication. That way dynamic environments like kubernetes can be fully supported as certificates with wildcard DNS can be used.
    
    
    ## Brief change log
    
    - Use CanonicalHostName instead of HostNameAddress to identify the server on the NettyClient
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as:
    
    NettyClientServerSslTest (org.apache.flink.runtime.io.network.netty)
       - testValidSslConnection
       - testSslHandshakeError 
    
    Also manually verified the change by running a 4 node kubernetes cluster with 1 JobManagers and 3 TaskManagers, using wildcard DNS certificates and executing a stateful streaming program with parallelism set to 2 and verifying that all nodes are able to communicate to each other successfully. 
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency):  no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EAlexRojas/flink release-1.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5789
    
----
commit 202672da7901fe7df912e6a057d6d0c29ccaf0fd
Author: EAlexRojas <al...@...>
Date:   2018-03-29T14:01:24Z

    Using CanonicalHostName instead of IP for SSL coonection on NettyClient

----


---

[GitHub] flink pull request #5789: [FLINK-9103] Using CanonicalHostName instead of IP...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5789


---