You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/21 04:09:34 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3801: ARTEMIS-3523: Expose replay through AddressControl

clebertsuconic commented on pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#issuecomment-948240642


   @nbrendah Nice job... you're getting there...It's midnight here and I made sure I came to look, because it looked almost good already...  
   
   a few minor adjustments and it will be ready to merge.. not bad! pretty much you have to remove the address parameter from the address control (the address control knows the address name already, that's the point), which will be delegated to the server's with the this.addressName from the address controller (I don't remember the actual variable name, but it will be there somehow).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org