You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/06/29 15:24:43 UTC
[GitHub] nifi-registry pull request #129: NIFIREG-181 Updated registry docker build t...
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi-registry/pull/129
NIFIREG-181 Updated registry docker build to make flow provider confi…
…gurable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-181
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit b3b632f9547049ee4b7094077e4a19d079a6b852
Author: Mike <mi...@...>
Date: 2018-06-29T15:04:54Z
NIFIREG-181 Updated registry docker build to make flow provider configurable.
----
---
[GitHub] nifi-registry issue #129: NIFIREG-181 Updated registry docker build to make ...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi-registry/pull/129
@apiri This too.
---
[GitHub] nifi-registry issue #129: NIFIREG-181 Updated registry docker build to make ...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi-registry/pull/129
@apiri rebased and pushed.
---
[GitHub] nifi-registry pull request #129: NIFIREG-181 Updated registry docker build t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-registry/pull/129
---
[GitHub] nifi-registry issue #129: NIFIREG-181 Updated registry docker build to make ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-registry/pull/129
Oh, and if you could rebase off master too, that would be great.
---
[GitHub] nifi-registry pull request #129: NIFIREG-181 Updated registry docker build t...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/129#discussion_r199486943
--- Diff: nifi-registry-docker/dockerhub/sh/update_flow_provider.sh ---
@@ -0,0 +1,42 @@
+#!/bin/sh -e
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+providers_file=${NIFI_REGISTRY_HOME}/conf/providers.xml
+property_xpath='/providers/flowPersistenceProvider'
+
+add_property() {
+ property_name=$1
+ property_value=$2
+
+ if [ -n "${property_value}" ]; then
+ xmlstarlet ed --subnode "/providers/flowPersistenceProvider" --type elem -n property -v "${property_value}" providers.xml | xmlstarlet ed --subnode "/providers/flowPersistenceProvider/property[not(name)]" --type attr -n name -v "${property_name}"
+ fi
+}
+
+xmlstarlet ed --inplace -u "${property_xpath}/property[@name='Flow Storage Directory']" -v "${NIFI_REGISTRY_FLOW_STORAGE_DIR:-./flow_storage}" "${providers_file}"
+
+case ${NIFI_REGISTRY_FLOW_PROVIDER} in
+ file)
--- End diff --
what are your thoughts on making this the default case?
---