You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/23 15:06:08 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12026: ARROW-12706: [Python] Drop Python 3.6 support

jorisvandenbossche commented on a change in pull request #12026:
URL: https://github.com/apache/arrow/pull/12026#discussion_r774627009



##########
File path: python/pyarrow/compat.pxi
##########
@@ -31,12 +29,8 @@ def encode_file_path(path):
     return encoded_path
 
 
-if sys.version_info >= (3, 7):
-    # Starting with Python 3.7, dicts are guaranteed to be insertion-ordered.
-    ordered_dict = dict
-else:
-    import collections
-    ordered_dict = collections.OrderedDict
+# Starting with Python 3.7, dicts are guaranteed to be insertion-ordered.
+ordered_dict = dict

Review comment:
       Not necessarily here, but I suppose we can also remove `ordered_dict` alltogether, and use `dict(..)` instead in the few places it is being used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org