You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jmesnil <gi...@git.apache.org> on 2016/09/12 09:37:21 UTC
[GitHub] activemq-artemis pull request #771: ARTEMIS-714 Improve JDBC Store
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/771
ARTEMIS-714 Improve JDBC Store
add DataSource and SQLProvider.Factory properties to DataStorageConfiguration to externalize the configuration of the communication with the JDBC data store instead of relying on global class path to load the SQL connection and hard-coded values for the SQL provider choice
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-714_JDBC_store
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #771
----
commit c2113b018177c3806c7dbad1f5ca8d2a0d383469
Author: Jeff Mesnil <jm...@gmail.com>
Date: 2016-09-08T15:46:09Z
ARTEMIS-714 Improve JDBC Store
add DataSource property to DatabaseStorageConfiguration to be able to
communicate with the data store using this DataSource instance instead
of relying on the creation the SQL connnection using the JDBC connection
URL/driver class name tuple.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
commit 84328f070b928d353ce81153c1b86a4f287db6cc
Author: Jeff Mesnil <jm...@gmail.com>
Date: 2016-09-09T14:47:03Z
ARTEMIS-714 Improve JDBC store
bindingsJournal and messageJournal are already started in the start()
method. Remove redundant calls that were creating unused JDBC
connections that are never closed.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
commit 94dc242d5374e51a3ee854faaaa305df399ed9c3
Author: Jeff Mesnil <jm...@gmail.com>
Date: 2016-09-12T09:17:53Z
ARTEMIS-714 Improve JDBC store
add SQLProvider.Factory property to DatabaseStorageConfiguration to
externalize the choice of the SQLProvider instead of relying on
hard-coded choices. If the property is null, the current behaviour will
be used (determing the SQLProvider based on the driver class name)
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-714
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
@jmesnil Could you please update the commit message to something more descriptive. e.g. Adds support for DataSource and SQL providers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
@jmesnil but the failure is real.
try it yourself:
# We disable checkstyles unless you are using the dev profile
mvn install -Pdev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
one last regressions:
org.apache.activemq.artemis.tests.integration.jdbc.store.journal.JDBCJournalTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #771: ARTEMIS-714 Improve JDBC Store
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
@jmesnil I don't think the retest works...
When I need that I do:
git commit --amend
git push origin -f
(and don't change anything.. just to change the commit ID)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
@jmesnil Can you take a look into org.apache.activemq.artemis.tests.integration.client.LargeMessage
If you run any JDBC test, there's a NPE happening:
```java
[main] 15:27:39,377 WARN [org.apache.activemq.artemis.core.server] AMQ222010: Critical IO Error, shutting down the server. file=NULL, message=null: java.lang.NullPointerException
at org.apache.activemq.artemis.core.persistence.impl.journal.JDBCJournalStorageManager.init(JDBCJournalStorageManager.java:89) [:]
at org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.<init>(AbstractJournalStorageManager.java:208) [:]
at org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.<init>(JournalStorageManager.java:97) [:]
at org.apache.activemq.artemis.core.persistence.impl.journal.JDBCJournalStorageManager.<init>(JDBCJournalStorageManager.java:47) [:]
at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:1799) [:]
at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:1930) [:]
at org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:61) [:]
at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:447) [:]
at org.apache.activemq.artemis.tests.integration.client.LargeMessageTest.testBufferMultipleLargeMessages(LargeMessageTest.java:1655) [:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.8.0_73]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [rt.jar:1.8.0_73]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_73]
at java.lang.reflect.Method.invoke(Method.java:497) [rt.jar:1.8.0_73]
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) [junit-4.11.jar:]
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [junit-4.11.jar:]
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) [junit-4.11.jar:]
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [junit-4.11.jar:]
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) [junit-4.11.jar:]
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) [junit-4.11.jar:]
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) [junit-4.11.jar:]
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) [junit-4.11.jar:]
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) [junit-4.11.jar:]
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) [junit-4.11.jar:]
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) [junit-4.11.jar:]
at org.junit.rules.RunRules.evaluate(RunRules.java:20) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) [junit-4.11.jar:]
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) [junit-4.11.jar:]
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.run(ParentRunner.java:309) [junit-4.11.jar:]
at org.junit.runners.Suite.runChild(Suite.java:127) [junit-4.11.jar:]
at org.junit.runners.Suite.runChild(Suite.java:26) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) [junit-4.11.jar:]
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) [junit-4.11.jar:]
at org.junit.runners.ParentRunner.run(ParentRunner.java:309) [junit-4.11.jar:]
at org.junit.runner.JUnitCore.run(JUnitCore.java:160) [junit-4.11.jar:]
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) [junit-rt.jar:]
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234) [junit-rt.jar:]
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74) [junit-rt.jar:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.8.0_73]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [rt.jar:1.8.0_73]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_73]
at java.lang.reflect.Method.invoke(Method.java:497) [rt.jar:1.8.0_73]
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144) [idea_rt.jar:]
```
I tried to fix it myself but I couldn't figure out your intention here. I guess you can fix it faster than I could.
I found this running the whole testsuite. The tests will hang after this failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #771: ARTEMIS-714 Improve JDBC Store
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
@jmesnil there was some changes I made to JDBC that are conflicting with this. Do you mine looking at them?
Also.. this is showing 3 commits.. shouldn't you squash them and push -f to your branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---