Re: [PR] add has_import_errors filter to Core API GET /dags endpoint [airflow]

["jason810496 (via GitHub)" <gi...@apache.org>]

jason810496 commented on code in PR #54563:
URL: https://github.com/apache/airflow/pull/54563#discussion_r2316557894


##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -614,6 +614,16 @@ def depends_float(
     FilterParam[bool | None],
     Depends(filter_param_factory(DagModel.is_paused, bool | None, filter_name="paused")),
 ]
+QueryHasImportErrorsFilter = Annotated[
+    FilterParam[bool | None],
+    Depends(
+        filter_param_factory(
+            DagModel.has_import_errors,
+            bool | None,
+            filter_name="has_import_errors",
+        )

Review Comment:
   I just merged the [Add description field for filter_param_factory #54903](https://github.com/apache/airflow/pull/54903) PR, it would be nice to rebase to the latest main and add the description referenced from parent issue.



##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -614,6 +614,16 @@ def depends_float(
     FilterParam[bool | None],
     Depends(filter_param_factory(DagModel.is_paused, bool | None, filter_name="paused")),
 ]
+QueryHasImportErrorsFilter = Annotated[
+    FilterParam[bool | None],
+    Depends(
+        filter_param_factory(
+            DagModel.has_import_errors,
+            bool | None,
+            filter_name="has_import_errors",
+        )

Review Comment:
   I just merged the [Add description field for filter_param_factory #54903](https://github.com/apache/airflow/pull/54903) PR, so it would be nice to rebase to the latest main and add the description referenced from parent issue. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org