You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/09/30 03:57:09 UTC
Review Request 14400: Implemented HostPort.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14400/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 1, 2013, 4:49 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/hostport.hpp, line 51
> > <https://reviews.apache.org/r/14400/diff/2/?file=359576#file359576line51>
> >
> > Please use braces.
oops. copy paste error from pid.cpp. will fix that one too.
> On Oct. 1, 2013, 4:49 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/hostport.hpp, line 126
> > <https://reviews.apache.org/r/14400/diff/2/?file=359576#file359576line126>
> >
> > We should probably pull all this into a helper, perhaps add a TODO?
added a todo.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26565
-----------------------------------------------------------
On Sept. 30, 2013, 2:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2013, 2:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26565
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51802>
I like the idea of making this explicit too.
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51803>
s/that/pid/
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51804>
Please use braces.
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51806>
Braces please (even though I imagine you copied this from another place).
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51808>
We should probably pull all this into a helper, perhaps add a TODO?
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51807>
You can kill these newlines.
- Benjamin Hindman
On Sept. 30, 2013, 2:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2013, 2:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26563
-----------------------------------------------------------
ping?
- Vinod Kone
On Sept. 30, 2013, 2:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2013, 2:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26577
-----------------------------------------------------------
Ship it!
TODO for UPID to use HostPort and kill the duplicated code?
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51821>
Looks like this is not needed? (I see your hash_value comment but that function should not require this to be included).
- Ben Mahler
On Oct. 1, 2013, 7:43 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 7:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
> 3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26579
-----------------------------------------------------------
3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51823>
Include the specific hash header for this instead?
- Ben Mahler
On Oct. 1, 2013, 7:43 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 7:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
> 3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 9, 2013, 6:40 p.m., Vinod Kone wrote:
> > For posterity, this review is being put on hold because the master now keys authenticated frameworks by pid instead of HostPort.
Now that we noticed Node in process.cpp we should probably pull that up instead of adding HostPort, if this gets revived :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26830
-----------------------------------------------------------
On Oct. 2, 2013, 10:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 10:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
> 3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26830
-----------------------------------------------------------
For posterity, this review is being put on hold because the master now keys authenticated frameworks by pid instead of HostPort.
- Vinod Kone
On Oct. 2, 2013, 10:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 10:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
> 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
> 3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
> 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14400/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/
-----------------------------------------------------------
(Updated Oct. 2, 2013, 10:42 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. NNFR.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14400/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 7:43 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's. NNFR.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
3rdparty/libprocess/include/process/pid.hpp 5a77dbc7b6917552536c936d1cc5791f24323bb7
3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710
3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14400/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14400: Implemented HostPort.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/
-----------------------------------------------------------
(Updated Sept. 30, 2013, 2:45 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
minor fixes.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7
3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION
3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14400/diff/
Testing
-------
make check
Thanks,
Vinod Kone