You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/01/04 19:06:57 UTC

Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/
-----------------------------------------------------------

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-19368
    https://issues.apache.org/jira/browse/AMBARI-19368


Repository: ambari


Description
-------

Add common log rotation settings to ranger, ranger-kms and falcon


Diffs
-----

  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml ecf68a9 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4a12b9f 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 6d1ae03 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ddbd9d7 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ac4e54e 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml 9f0cdbf 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml afeb422 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 768c153 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 20b2dc1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 82dcb6b 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py f5e55b3 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 36fa15b 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 42f75e2 

Diff: https://reviews.apache.org/r/55182/diff/


Testing
-------

Verified changes through API and Database


Thanks,

Madhuvanthi Radhakrishnan


Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/#review160532
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 4, 2017, 7:06 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55182/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19368
>     https://issues.apache.org/jira/browse/AMBARI-19368
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add common log rotation settings to ranger, ranger-kms and falcon
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml ecf68a9 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4a12b9f 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 6d1ae03 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ddbd9d7 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ac4e54e 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml 9f0cdbf 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml afeb422 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 768c153 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 20b2dc1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 82dcb6b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py f5e55b3 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 36fa15b 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 42f75e2 
> 
> Diff: https://reviews.apache.org/r/55182/diff/
> 
> 
> Testing
> -------
> 
> Verified changes through API and Database
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>


Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/#review161762
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On Jan. 5, 2017, 4:33 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55182/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19368
>     https://issues.apache.org/jira/browse/AMBARI-19368
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add common log rotation settings to ranger, ranger-kms and falcon
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml ecf68a9 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4a12b9f 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 6d1ae03 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ddbd9d7 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ac4e54e 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml 9f0cdbf 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml afeb422 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 768c153 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 20b2dc1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7fb8ba6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 82dcb6b 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 8079147 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 4ad5c0f 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json f2a0405 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py f5e55b3 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 36fa15b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 3d79e0a 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 42f75e2 
> 
> Diff: https://reviews.apache.org/r/55182/diff/
> 
> 
> Testing
> -------
> 
> Verified changes through API and Database
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>


Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/#review160606
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 5, 2017, 4:33 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55182/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19368
>     https://issues.apache.org/jira/browse/AMBARI-19368
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add common log rotation settings to ranger, ranger-kms and falcon
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml ecf68a9 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4a12b9f 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 6d1ae03 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ddbd9d7 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ac4e54e 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml 9f0cdbf 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml afeb422 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 768c153 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 20b2dc1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7fb8ba6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 82dcb6b 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 8079147 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 4ad5c0f 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json f2a0405 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py f5e55b3 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 36fa15b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 3d79e0a 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 42f75e2 
> 
> Diff: https://reviews.apache.org/r/55182/diff/
> 
> 
> Testing
> -------
> 
> Verified changes through API and Database
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>


Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 4:33 p.m.)


Review request for Ambari and Sumit Mohanty.


Changes
-------

Modified some test scripts for falcon.


Bugs: AMBARI-19368
    https://issues.apache.org/jira/browse/AMBARI-19368


Repository: ambari


Description
-------

Add common log rotation settings to ranger, ranger-kms and falcon


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml ecf68a9 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 4a12b9f 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 6d1ae03 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ddbd9d7 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ac4e54e 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml 9f0cdbf 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml afeb422 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml 768c153 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml 20b2dc1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7fb8ba6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 82dcb6b 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 8079147 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 4ad5c0f 
  ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json f2a0405 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py f5e55b3 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 36fa15b 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 3d79e0a 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 42f75e2 

Diff: https://reviews.apache.org/r/55182/diff/


Testing
-------

Verified changes through API and Database


Thanks,

Madhuvanthi Radhakrishnan