You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/03/06 08:20:46 UTC

[GitHub] [storm] danny0405 commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

danny0405 commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…
URL: https://github.com/apache/storm/pull/2945#discussion_r250537141
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/testing/FixedTupleSpout.java
 ##########
 @@ -131,8 +130,6 @@ public void nextTuple() {
             String id = UUID.randomUUID().toString();
             _pending.put(id, ft);
             _collector.emit(ft.stream, ft.values, id);
-        } else {
-            Utils.sleep(100);
 
 Review comment:
   Why remove this sleep, can this cause CPU hotspot if _serverTuples is always empty ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services