You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/08/19 10:20:08 UTC
[GitHub] brooklyn-dist pull request #42: OSGi features cleanup
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-dist/pull/42
OSGi features cleanup
Depends on https://github.com/apache/brooklyn-server/pull/303
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-dist osgi/features-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 3070fd1ffac552c8353aade184d9b680fff31bd0
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-08-19T09:54:45Z
OSGi features cleanup
Split loading in chunks by using prerequisite flag.
commit 78dd048b7b0a21d81616865e389d897cf03efb83
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-08-19T09:55:03Z
jstack helper script to dump a single named thread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #42: OSGi features cleanup
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/42#discussion_r75463853
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<features xmlns="http://karaf.apache.org/xmlns/features/v1.2.0"
+ name="org.apache.brooklyn-${project.version}"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:noNamespaceSchemaLocation="http://karaf.apache.org/xmlns/features/v1.2.0">
+
+ <feature name="brooklyn-startup-features" version="${project.version}" description="Bundles to add to startup.properties">
+ <!-- Register javax.mail along with pax-logging-service so it doesn't get refreshed later -->
+ <bundle>mvn:javax.mail/mail/${javax.mail.version}</bundle>
+ </feature>
+
+ <feature name="brooklyn-guava-optional-deps" version="${project.version}" description="Guava dependencies to avoid refreshing the bundle">
+ <!-- Register javax.annotation (coming from cxf-jaxrs) before guava so it doesn't get rewired when it sees it -->
+ <bundle>mvn:javax.annotation/javax.annotation-api/${cxf.javax.annotation-api.version}</bundle>
+ </feature>
+
+ <feature name="brooklyn-headless" version="${project.version}" description="All Brooklyn bundles witht the exception of the launcher">
+ <feature prerequisite="true">standard</feature>
+ <feature prerequisite="true">brooklyn-guava-optional-deps</feature>
+ <feature>brooklyn-core</feature>
+ <feature>brooklyn-rest-resources</feature>
+ <feature>brooklyn-commands</feature>
+ <feature>brooklyn-server-software-all</feature>
+ <feature>brooklyn-library-all</feature>
+ <feature>brooklyn-locations-jclouds</feature>
+ </feature>
+
+ <feature name="brooklyn-jsgui-prereqs" version="${project.version}" description="Brooklyn REST JavaScript Web GUI">
+ <feature>pax-jetty</feature> <!-- jaas bundle -->
+ <bundle>mvn:org.apache.brooklyn/brooklyn-karaf-jetty-config/${project.version}</bundle>
+ <feature>war</feature>
+ </feature>
+
+ <feature name="brooklyn-jsgui" version="${project.version}" description="Brooklyn REST JavaScript Web GUI">
+ <feature>brooklyn-jsgui-prereqs</feature>
+ <bundle>mvn:org.apache.brooklyn/brooklyn-jsgui/${project.version}/war</bundle>
+ </feature>
+
+ <feature name="brooklyn-boot" version="${project.version}" description="Bundles to start on boot">
+ <feature prerequisite="true">brooklyn-with-ui</feature>
--- End diff --
When I tried to build this I get:
```
[ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.0.4:assembly (default-assembly) on project apache-brooklyn: Unable to build assembly: Could not find matching feature for brooklyn-with-ui -> [Help 1]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #42: OSGi features cleanup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #42: OSGi features cleanup
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/42#discussion_r75464066
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<features xmlns="http://karaf.apache.org/xmlns/features/v1.2.0"
+ name="org.apache.brooklyn-${project.version}"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:noNamespaceSchemaLocation="http://karaf.apache.org/xmlns/features/v1.2.0">
+
+ <feature name="brooklyn-startup-features" version="${project.version}" description="Bundles to add to startup.properties">
+ <!-- Register javax.mail along with pax-logging-service so it doesn't get refreshed later -->
+ <bundle>mvn:javax.mail/mail/${javax.mail.version}</bundle>
+ </feature>
+
+ <feature name="brooklyn-guava-optional-deps" version="${project.version}" description="Guava dependencies to avoid refreshing the bundle">
+ <!-- Register javax.annotation (coming from cxf-jaxrs) before guava so it doesn't get rewired when it sees it -->
+ <bundle>mvn:javax.annotation/javax.annotation-api/${cxf.javax.annotation-api.version}</bundle>
+ </feature>
+
+ <feature name="brooklyn-headless" version="${project.version}" description="All Brooklyn bundles witht the exception of the launcher">
+ <feature prerequisite="true">standard</feature>
+ <feature prerequisite="true">brooklyn-guava-optional-deps</feature>
+ <feature>brooklyn-core</feature>
+ <feature>brooklyn-rest-resources</feature>
+ <feature>brooklyn-commands</feature>
+ <feature>brooklyn-server-software-all</feature>
+ <feature>brooklyn-library-all</feature>
+ <feature>brooklyn-locations-jclouds</feature>
+ </feature>
+
+ <feature name="brooklyn-jsgui-prereqs" version="${project.version}" description="Brooklyn REST JavaScript Web GUI">
+ <feature>pax-jetty</feature> <!-- jaas bundle -->
+ <bundle>mvn:org.apache.brooklyn/brooklyn-karaf-jetty-config/${project.version}</bundle>
+ <feature>war</feature>
+ </feature>
+
+ <feature name="brooklyn-jsgui" version="${project.version}" description="Brooklyn REST JavaScript Web GUI">
+ <feature>brooklyn-jsgui-prereqs</feature>
+ <bundle>mvn:org.apache.brooklyn/brooklyn-jsgui/${project.version}/war</bundle>
+ </feature>
+
+ <feature name="brooklyn-boot" version="${project.version}" description="Bundles to start on boot">
+ <feature prerequisite="true">brooklyn-with-ui</feature>
--- End diff --
Sorry about that, didn't push the latest changes. Should be all good now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #42: OSGi features cleanup
Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-dist/pull/42
successfully tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #42: OSGi features cleanup
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-dist/pull/42
Looks good to me from review point of view and AMP starts successfully. Haven't tested a large number of restarts using the script though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---