You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2019/07/12 09:53:00 UTC
[jira] [Comment Edited] (LUCENE-8911) Backport LUCENE-8778
(improved analysis SPI name handling) to 8.x
[ https://issues.apache.org/jira/browse/LUCENE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883687#comment-16883687 ]
Uwe Schindler edited comment on LUCENE-8911 at 7/12/19 9:52 AM:
----------------------------------------------------------------
My opinion/idea would be the following:
- Backport everything to 8.x
- In addition to extracting the {{NAME}} field (which should not fail the SPI lookup) also generate the "old name". Add both names to the map (they may differ, if a user decides to use his own name).
This would bring both worlds:
- Old factories still work (using the old algorithm) to generate the name
- New factories would have both names (ideally they should not differ, but with the new aproach the user should be able to decide for his own name, not generated from the factory class name).
We should add a test with a fake factory (maybe add a META-INF file to the tests) without NAME to test backwards compatibility.
was (Author: thetaphi):
My opinion/idea would be the following:
- Backport everything to 8.x
- In addition to extracting the {{NAME}} field (which should not fail the build) also generate the "old name". Add both names to the map (they may differ, if a user decides to use his own name).
This would bring both worlds:
- Old factories still work (using the old algorithm) to generate the name
- New factories would have both names (ideally they should not differ, but with the new aproach the user should be able to decide for his own name, not generated from the factory class name).
We should add a test with a fake factory (maybe add a META-INF file to the tests) without NAME to test backwards compatibility.
> Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
> -----------------------------------------------------------------
>
> Key: LUCENE-8911
> URL: https://issues.apache.org/jira/browse/LUCENE-8911
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Priority: Minor
>
> In LUCENE-8907 I reverted LUCENE-8778 from the 8x branch.
> Can we backport it to 8x branch again, with transparent backwards compatibility (by emulating the factory loading method of Lucene 8.1)?
> I am not so sure about it would be better or not to backport the changes, however, maybe it is good for Solr to have SOLR-13593 without waiting for release 9.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org