You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/14 18:51:40 UTC

Review Request 56676: ATLAS-1557: IDBased resolver updated to attempt unique-attribute match as well

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56676/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1557
    https://issues.apache.org/jira/browse/ATLAS-1557


Repository: atlas


Description
-------

IDBased resolver updated to attempt unique-attribute match as well


Diffs
-----

  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java b3fa370 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java f24cab3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java 41ea75b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java 17b102a 

Diff: https://reviews.apache.org/r/56676/diff/


Testing
-------

Verified that unit tests pass


Thanks,

Madhan Neethiraj


Re: Review Request 56676: ATLAS-1557: IDBased resolver updated to attempt unique-attribute match as well

Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56676/#review165561
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 14, 2017, 10:51 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56676/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 10:51 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1557
>     https://issues.apache.org/jira/browse/ATLAS-1557
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> IDBased resolver updated to attempt unique-attribute match as well
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java b3fa370 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java f24cab3 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java 41ea75b 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java 17b102a 
> 
> Diff: https://reviews.apache.org/r/56676/diff/
> 
> 
> Testing
> -------
> 
> Verified that unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 56676: ATLAS-1557: IDBased resolver updated to attempt unique-attribute match as well

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56676/
-----------------------------------------------------------

(Updated Feb. 14, 2017, 8:05 p.m.)


Review request for atlas.


Changes
-------

fixed incorrect unit test


Bugs: ATLAS-1557
    https://issues.apache.org/jira/browse/ATLAS-1557


Repository: atlas


Description
-------

IDBased resolver updated to attempt unique-attribute match as well


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java b3fa370 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java f24cab3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java 41ea75b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java 17b102a 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e493345 

Diff: https://reviews.apache.org/r/56676/diff/


Testing
-------

Verified that unit tests pass


Thanks,

Madhan Neethiraj