[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283645950
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/DeclarativeAggregateFunction.java
 ##########
 @@ -62,7 +62,7 @@
 	/**
 	 * All types of the aggregate buffer.
 	 */
-	public abstract InternalType[] getAggBufferTypes();
+	public abstract LogicalType[] getAggBufferTypes();
 
 Review comment:
   I have different thought.
   The `DeclarativeAggregateFunction` does not expose physical representation. It is the interface to description logic computing for user.
   
   >The DataType class has two responsibilities: declaring a logical type and giving hints about the physical representation of data to the optimizer. While the logical type is mandatory, hints are optional but useful at the edges to other APIs.
   
   So I think we should use `LogicalType` for `getAggBufferTypes` and `getResultType`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services