[GitHub] [couchdb-erlfdb] nickva commented on a change in pull request #26: Ensure application environment is loaded

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #26:
URL: https://github.com/apache/couchdb-erlfdb/pull/26#discussion_r649666369



##########
File path: src/erlfdb_util.erl
##########
@@ -48,6 +48,8 @@ get_test_db(Options) ->
 
 
 init_test_cluster(Options) ->
+    % Hack to ensure erlfdb app environment is loaded during unit tests
+    ok = application:ensure_started(erlfdb),

Review comment:
       Normally it would be `{ok, _} = application:ensure_all_started(erlfdb).` but as `erldb` only depends on kernel and stdlib probably doesn't do to the extra work.

##########
File path: src/erlfdb_util.erl
##########
@@ -48,6 +48,8 @@ get_test_db(Options) ->
 
 
 init_test_cluster(Options) ->
+    % Hack to ensure erlfdb app environment is loaded during unit tests
+    ok = application:ensure_started(erlfdb),

Review comment:
       Normally it would be `{ok, _} = application:ensure_all_started(erlfdb).` but as `erldb` only depends on kernel and stdlib probably doesn't need to do the extra work checking recursive dependencies




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org