You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2010/07/31 02:56:18 UTC
[jira] Created: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
when generating reentrant INSERT for index rebuild, quote identifiers using backticks
-------------------------------------------------------------------------------------
Key: HIVE-1501
URL: https://issues.apache.org/jira/browse/HIVE-1501
Project: Hadoop Hive
Issue Type: Bug
Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: He Yongqiang
Fix For: 0.7.0
Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Attachment: HIVE-1501.5.patch
Moved function from MetaStoreUtils to HiveUtils.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch, HIVE-1501.5.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Attachment: 1501_with_tests.patch
Adding a patch for 1501 that also includes tests.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Attachment: 1501.patch
Patch for 1501
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913723#action_12913723 ]
John Sichi commented on HIVE-1501:
----------------------------------
Example:
create table `_t`(`_i` int, `_j` int);
create index x on table `_t`(`_j`) as 'compact' with deferred rebuild;
alter index x on `_t` rebuild;
gives
FAILED: Parse Error: line 1:48 mismatched input ',' expecting CharSetLiteral in character string literal
To see why, look at org.apache.hadoop.hive.ql.index.compact.CompactIndexHandler, method getIndexBuilderMapRedTask. It constructs an internal SQL statement (INSERT) which populates the index table structure. However, it neglects to quote the table/column names, leading to invalid syntax. (Hive uses backticks to quote identifiers with special characters--I think this currently only applies to leading underscores, but later we'll support arbitrary identifiers.)
HiveUtils.unparseIdentifier should be used for quoting.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: He Yongqiang
> Fix For: 0.7.0
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928295#action_12928295 ]
John Sichi commented on HIVE-1501:
----------------------------------
+1. Will commit when tests pass.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HIVE-1501) when generating reentrant
INSERT for index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913731#action_12913731 ]
John Sichi edited comment on HIVE-1501 at 9/22/10 3:22 PM:
-----------------------------------------------------------
Russell, please reassign to the actual owner.
was (Author: jvs):
Russell, please reasssign to the actual owner.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Russell Melick
> Fix For: 0.7.0
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925618#action_12925618 ]
He Yongqiang commented on HIVE-1501:
------------------------------------
String indexCols = MetaStoreUtils.getColumnNamesFromFieldSchema(indexField);
indexCols is a column list, like:
col1, col2,col3
After the change, it should be `col1`, `col2`, `col3`...
So the whole command should be like:
INSERT OVERWRITE TABLE `table_name`
PARTITION (...)
SELECT `col1`, `col2`, `col3`..., `INPUT__FILE__NAME`, collect_set (`BLOCK__OFFSET__INSIDE__FILE`)
FROM `base_table`
...
GROUP BY `col1`, `col2`, `col3`..., `INPUT__FILE__NAME`
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1501:
-----------------------------
Status: Open (was: Patch Available)
Oops, I have to retract my +1.
The patch doesn't compile with "ant package". The reason is that code in metastore is not allowed to depend on code in ql.
If you were compiling with Eclipse, it may have allowed this, but before submitting your patch, make sure it compiles from the command line with "ant package".
The solution is to move this method from MetastoreUtils to HiveUtils.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi reassigned HIVE-1501:
--------------------------------
Assignee: Russell Melick (was: He Yongqiang)
Russell, please reasssign to the actual owner.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Russell Melick
> Fix For: 0.7.0
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-1501:
-------------------------------
Status: Open (was: Patch Available)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Status: Patch Available (was: Open)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1501:
-----------------------------
Status: Open (was: Patch Available)
Whitespace nitpicks:
* MetaStoreUtils.java no longer has any changes, so it should not be in the patch at all
*
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch, HIVE-1501.5.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919174#action_12919174 ]
Skye Berghel commented on HIVE-1501:
------------------------------------
I've added a patch that should solve the issue.
In terms of tests, is a simple test (of the kind John described in his earlier comment) sufficient?
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Attachment: 1501_new_tests.patch
Adding a new patch for 1501 that parses the index columns correctly.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1501:
-----------------------------
Status: Open (was: Patch Available)
Can you update the testcase to use an index on a compound key so that this case gets coverage?
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Status: Patch Available (was: Open)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Status: Patch Available (was: Open)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch, HIVE-1501.5.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919960#action_12919960 ]
John Sichi commented on HIVE-1501:
----------------------------------
Yes, a simple test such as the one above should be good enough.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Attachment: HIVE-1501.4.patch
Adding a new patch with a new test case for an index with multiple keys.
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929766#action_12929766 ]
John Sichi commented on HIVE-1501:
----------------------------------
* HiveUtils.getUnparsedColumnNamesFromFieldSchema has an extra line of whitespace in between the Javadoc and the method declaration.
(If you're using Eclipse for editing, it's easy to end up with extraneous whitespace.)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch, HIVE-1501.5.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Russell Melick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell Melick reassigned HIVE-1501:
------------------------------------
Assignee: Skye Berghel (was: Russell Melick)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929769#action_12929769 ]
John Sichi commented on HIVE-1501:
----------------------------------
(Other than those, this one should be ready to go.)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_new_tests.patch, 1501_with_tests.patch, HIVE-1501.4.patch, HIVE-1501.5.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1501) when generating reentrant INSERT for
index rebuild, quote identifiers using backticks
Posted by "Skye Berghel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Berghel updated HIVE-1501:
-------------------------------
Status: Patch Available (was: Open)
> when generating reentrant INSERT for index rebuild, quote identifiers using backticks
> -------------------------------------------------------------------------------------
>
> Key: HIVE-1501
> URL: https://issues.apache.org/jira/browse/HIVE-1501
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Skye Berghel
> Fix For: 0.7.0
>
> Attachments: 1501.patch, 1501_with_tests.patch
>
>
> Yongqiang, you mentioned that you weren't able to do this due to SORT BY not accepting them. The SORT BY is gone now as of HIVE-1494 (and SORT BY needs to be fixed anyway).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.