[GitHub] [arrow] emkornfield commented on a change in pull request #12763: ARROW-14892: [Python][C++] GCS Bindings

[GitBox <gi...@apache.org>]

emkornfield commented on a change in pull request #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r841092427



##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -536,8 +546,7 @@ class GcsFileSystem::Impl {
                                                            gcs::ReadFromOffset offset) {
     auto stream = client_.ReadObject(path.bucket, path.object, generation, offset);
     ARROW_GCS_RETURN_NOT_OK(stream.status());
-    return std::make_shared<GcsInputStream>(std::move(stream), path, gcs::Generation(),
-                                            offset, client_);
+    return std::make_shared<GcsInputStream>(std::move(stream), path, generation, client_);

Review comment:
       Empirically the underlying tell returns 1000.  I was observing doubling of expected tell value.  The python test that found this wrote N bytes the seemed to N/2 and tried reading.  The reading called the FS tell which returned N




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org