You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@zeppelin.apache.org by "jongyoul (via GitHub)" <gi...@apache.org> on 2023/09/11 14:09:04 UTC

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4651: [ZEPPELIN-5792][FRONT_BUILD] Remove bower

jongyoul commented on code in PR #4651:
URL: https://github.com/apache/zeppelin/pull/4651#discussion_r1321616603


##########
pom.xml:
##########
@@ -111,8 +111,8 @@
     <scalacheck.version>1.12.5</scalacheck.version>
 
     <!-- frontend maven plugin related versions-->
-    <node.version>v12.3.1</node.version>
-    <npm.version>6.9.0</npm.version>
+    <node.version>v14.17.0</node.version>

Review Comment:
   I'm not an expert but some newer versions of nodes cannot build the current Zeppelin's code as it is. I agree that we need to update to the latest version but we could have another PR if it leads to a lot of changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org