[GitHub] [pulsar] dlg99 commented on pull request #15914: [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

[GitBox <gi...@apache.org>]

dlg99 commented on PR #15914:
URL: https://github.com/apache/pulsar/pull/15914#issuecomment-1147688612

   @hangc0276 
   > Even though we should delete the offload data on topic deletion, it has changed the default behavior. We'd better have a proposal to discuss it.
   
   I disagree that undocumented silently orphaned data (without tools/automated processes to detect it and clean up) is a "default behavior" one ever expected or wanted. It looks like a bug that just happened.
   
   > Another one is that it can't prevent orphan ledgers because they offloaded data deletion is async.
   
   In case of truncate internalTrimLedgers runs with `isTruncate == true` actual future that completes when trimming is done, and the topic deletion will follow that. 
   In case of deletion we have `isTruncate == false` and  internalTrimLedgers runs with Futures.NULL_PROMISE.
    
   In case I missed some place where internalTrimLedgers completes the promise before the data deletion is done i'll fix that as long as we agree on overall approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org