You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Mike Edwards (JIRA)" <tu...@ws.apache.org> on 2008/01/11 15:25:33 UTC
[jira] Created: (TUSCANY-1962) WSDL2JAVA Test not valid -
generating code that is not checked
WSDL2JAVA Test not valid - generating code that is not checked
--------------------------------------------------------------
Key: TUSCANY-1962
URL: https://issues.apache.org/jira/browse/TUSCANY-1962
Project: Tuscany
Issue Type: Bug
Components: Java SCA Tools
Affects Versions: Java-SCA-1.1
Environment: All
Reporter: Mike Edwards
Priority: Minor
Fix For: Java-SCA-Next
The WSDL2Java tools has a testcase WSDL2JavaGeneratorTestcase that is an invalid testcase.
This testcase runs the WSDL2Java tool and generates some output Java classes based on an input WSDL document. The files get placed into the target/wsdl2java-source directory. The current testcase only generates these files - it does not check that their contents are meaningful or correct. In reality, the generated code has problems:
a) The code refers to SDO classes that are not generated by the testcase and which are not available in any obvious location. As a result the code does not compile.
b) The generated code does not have import statements for the SDO classes that are used. Instead, the classes are used with full paths on each declaration. At the very least this is unacceptable style and it should be changed.
There is no attempt in the test to check that the generated code conforms to some expected output. The test MUST be extended to do this if it is to be of any real value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Reopened: (TUSCANY-1962) WSDL2JAVA Test not valid -
generating code that is not checked
Posted by "Luciano Resende (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende reopened TUSCANY-1962:
--------------------------------------
Reopening based on discussions on the following thread :
http://www.mail-archive.com/tuscany-dev%40ws.apache.org/msg26939.html
Suggestion from Sebastien is to have :
- Unit tests of the wsdl2java logic that check the expected output
(without compiling it or trying to use the generated code).
- Integration tests that compile the generated code.
- Integration tests that compile and use the generated code at runtime
(start with wsdls on both ends of a wire, gen the java, compile, execute
an end to end interaction).
> WSDL2JAVA Test not valid - generating code that is not checked
> --------------------------------------------------------------
>
> Key: TUSCANY-1962
> URL: https://issues.apache.org/jira/browse/TUSCANY-1962
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Tools
> Affects Versions: Java-SCA-1.1
> Environment: All
> Reporter: Mike Edwards
> Priority: Minor
> Fix For: Java-SCA-Next
>
>
> The WSDL2Java tools has a testcase WSDL2JavaGeneratorTestcase that is an invalid testcase.
> This testcase runs the WSDL2Java tool and generates some output Java classes based on an input WSDL document. The files get placed into the target/wsdl2java-source directory. The current testcase only generates these files - it does not check that their contents are meaningful or correct. In reality, the generated code has problems:
> a) The code refers to SDO classes that are not generated by the testcase and which are not available in any obvious location. As a result the code does not compile.
> b) The generated code does not have import statements for the SDO classes that are used. Instead, the classes are used with full paths on each declaration. At the very least this is unacceptable style and it should be changed.
> There is no attempt in the test to check that the generated code conforms to some expected output. The test MUST be extended to do this if it is to be of any real value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1962) WSDL2JAVA Test not valid -
generating code that is not checked
Posted by "Luciano Resende (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende resolved TUSCANY-1962.
--------------------------------------
Resolution: Invalid
The wsdl2java test case only test that the wsdl tool works ok and can process and generate the java artifacts from wsdl.
The full integration test, that generates and compile the generated artifacts is available in iTest\wsdl2java.
Please reopen the JIRA if you disagree with the way it's structured today.
> WSDL2JAVA Test not valid - generating code that is not checked
> --------------------------------------------------------------
>
> Key: TUSCANY-1962
> URL: https://issues.apache.org/jira/browse/TUSCANY-1962
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Tools
> Affects Versions: Java-SCA-1.1
> Environment: All
> Reporter: Mike Edwards
> Priority: Minor
> Fix For: Java-SCA-Next
>
>
> The WSDL2Java tools has a testcase WSDL2JavaGeneratorTestcase that is an invalid testcase.
> This testcase runs the WSDL2Java tool and generates some output Java classes based on an input WSDL document. The files get placed into the target/wsdl2java-source directory. The current testcase only generates these files - it does not check that their contents are meaningful or correct. In reality, the generated code has problems:
> a) The code refers to SDO classes that are not generated by the testcase and which are not available in any obvious location. As a result the code does not compile.
> b) The generated code does not have import statements for the SDO classes that are used. Instead, the classes are used with full paths on each declaration. At the very least this is unacceptable style and it should be changed.
> There is no attempt in the test to check that the generated code conforms to some expected output. The test MUST be extended to do this if it is to be of any real value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org