You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by SparshSinghalHM <gi...@git.apache.org> on 2018/08/10 10:55:05 UTC

[GitHub] incubator-griffin pull request #392: Update pom.xml

GitHub user SparshSinghalHM opened a pull request:

    https://github.com/apache/incubator-griffin/pull/392

    Update pom.xml

    Uncomment Mysql Connector dependency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SparshSinghalHM/incubator-griffin patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #392
    
----
commit 2d241b8bd1055f056f8ced5a327365306ce2842d
Author: Sparsh Singhal <sp...@...>
Date:   2018-08-10T10:54:45Z

    Update pom.xml
    
    Uncomment Mysql Connector dependency.

----


---

[GitHub] incubator-griffin issue #392: Update pom.xml

Posted by SparshSinghalHM <gi...@git.apache.org>.

Github user SparshSinghalHM commented on the issue:

    https://github.com/apache/incubator-griffin/pull/392
  
    Hi @guoyuepeng 
    
    Can we mention this in the document? 
    Also, can we update the document with the latest updates? 
    
    Thanks for responding.
    
    Sparsh


---

[GitHub] incubator-griffin issue #392: Update pom.xml

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/392
  
    @SparshSinghalHM 
    
    We are updating for our documents.
    
    Thanks,
    William


---

[GitHub] incubator-griffin issue #392: Update pom.xml

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/392
  
    Hi @SparshSinghalHM 
    
    Thanks for your PR, but we cannot use mysql in our primary pom.xml directly 
    since its license not compatible with apache community.
    
    so if you want to use mysql as storage, please use this pom as your build pom
    
    https://github.com/apache/incubator-griffin/blob/master/service/hibernate_mysql_pom.xml
    
    Thanks for your understanding.
    
    William
    
    



---

[GitHub] incubator-griffin pull request #392: Update pom.xml

Posted by SparshSinghalHM <gi...@git.apache.org>.

Github user SparshSinghalHM closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/392


---