You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rombert (via GitHub)" <gi...@apache.org> on 2023/06/08 13:08:33 UTC
[GitHub] [sling-org-apache-sling-scripting-core] rombert opened a new pull request, #23: SLING-11904 - Sling Scripting Core build fails on Java 17 due to Mockito error:module java.base does not "opens java.lang" to unnamed module @2613a93a
rombert opened a new pull request, #23:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/23
- use the latest version of mockito
- replace mockito-internal Whitebox with FieldUtils from commons-lang3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #23: SLING-11904 - Sling Scripting Core build fails on Java 17 due to Mockito error:module java.base does not "opens java.lang" to unnamed module @2613a93a
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #23:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/23#issuecomment-1582602114
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=23&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] rombert commented on pull request #23: SLING-11904 - Sling Scripting Core build fails on Java 17 due to Mockito error:module java.base does not "opens java.lang" to unnamed module @2613a93a
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #23:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/23#issuecomment-1582636301
The `test` phase passes now on Java 17, but the Pax-Exam integration tests fail
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ExcludeScriptEngineIT$ExcludedIT.testScriptEngineFactoryNotPresent:179 Expected nashorn ScriptEngine to exist
[ERROR] ExcludeScriptEngineIT$NotExcludedIT.testScriptEngineFactoryPresent:141 Expected nashorn ScriptEngine to exist
[ERROR] Errors:
[ERROR] HtmlScriptingIT.testHtlTitle » ServiceLookup gave up waiting for service org.a...
[ERROR] HtmlScriptingIT.testThymeleafTitle » ServiceLookup gave up waiting for service...
[ERROR] SLING_10147IT$HasNoWebConsoleSecurityProvider2IT.testGetSlingBindingsVariablesListJsonWithoutWebConsoleSecurityProvider2 » InaccessibleObject
[ERROR] SLING_10147IT$NotAuthorizedIT.testGetSlingBindingsVariablesListJsonWithAnonymousUser » InaccessibleObject
[ERROR] SLING_10147IT$NotAuthorizedIT.testGetSlingBindingsVariablesListJsonWithNotAuthorizedUser » Socket
[ERROR] SLING_10147IT » TestContainer java.rmi.ConnectException: Connection refused to...
[ERROR] SLING_11398IT.initializationError » TestContainer java.lang.IllegalStateExcept...
[ERROR] SLING_5720IT.initializationError » TestContainer java.lang.IllegalStateExcepti...
[INFO]
```
I think we should merge this nevertheless as it improves the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] rombert merged pull request #23: SLING-11904 - Sling Scripting Core build fails on Java 17 due to Mockito error:module java.base does not "opens java.lang" to unnamed module @2613a93a
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert merged PR #23:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org