[jira] [Comment Edited] (FELIX-5404) Annotation configurations default values are not considered

["Julian Sedding (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748160#comment-15748160 ] 

Julian Sedding edited comment on FELIX-5404 at 12/14/16 12:00 PM:
------------------------------------------------------------------

[~cziegeler] you mean a test that tests the entire stack? I'll try to find the time. Please note that I *did* get unexpected NPEs due to missing null checks on the return values of annotation methods with default values.


was (Author: jsedding):
[~cziegeler] you mean an test that tests the entire stack? I'll try to find the time. Please note that I *did* get unexpected NPEs due to missing null checks on the return values of annotation methods with default values.

> Annotation configurations default values are not considered
> -----------------------------------------------------------
>
>                 Key: FELIX-5404
>                 URL: https://issues.apache.org/jira/browse/FELIX-5404
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-2.0.6
>            Reporter: Julian Sedding
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: scr-2.1.0
>
>         Attachments: FELIX-5404-jsedding.patch
>
>
> When an annotation is used to configure an SCR component (as per DS 1.3), the annotation's default values are not considered.
> This can lead to the odd situation that an annotation method with a default value returns null. I'm not sure if this violates a contract or another, however, my IDE complains when I do a null check.
> I think it would be the right thing to do to return the default value if no value is explicitly configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)