You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/06 09:22:40 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4016: Fixed
private gateway can't be deleted
Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016
## Description
<!--- Describe your changes in detail -->
When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state.
Currently, the UI doesn't distinguish between active or revoked static routes.
This PR adds the missing state filter to the list routes command and only lists active routes in the UI.
It also ignores revoked routes when the private gateway is being removed but clears out the inactive routes after the gateway is removed.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes #2908
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This has been tested by creating a VPC with no services, adding a private gateway, adding a static route and deleting the gateway.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609685570
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed
private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330
> In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
@weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed
private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330
> In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
@weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610938614
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330
> In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
@weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request
#4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#discussion_r403958913
##########
File path: engine/schema/src/main/java/com/cloud/network/vpc/dao/StaticRouteDao.java
##########
@@ -30,6 +30,8 @@
List<StaticRouteVO> listByVpcId(long vpcId);
+ List<StaticRouteVO> listByGatewayId(long vpcId);
Review comment:
Renamed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610962532
Packaging result: ✔centos7 ✔debian. JID-1153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-611448231
> > > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
> >
> >
> > @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go?
>
> @Spaceman1984 I think it would be better to remove the record if there is error/exception in the creation.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#4016: Fixed private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#discussion_r403956830
##########
File path: engine/schema/src/main/java/com/cloud/network/vpc/dao/StaticRouteDao.java
##########
@@ -30,6 +30,8 @@
List<StaticRouteVO> listByVpcId(long vpcId);
+ List<StaticRouteVO> listByGatewayId(long vpcId);
Review comment:
gatewayId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed
private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330
> In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
@weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610410060
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610939063
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610410777
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4016: Fixed private
gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610426270
Packaging result: ✔centos7 ✔debian. JID-1145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed
private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330
> In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
@weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #4016: [WIP] Fixed
private gateway can't be deleted
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4016: [WIP] Fixed private gateway can't be deleted
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-610567918
> > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ?
>
> @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go?
@Spaceman1984 I think it would be better to remove the record if there is error/exception in the creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services